get license clearance for linkification code

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

unspecified
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

3 years ago
The automatic linkification regular expression in bug 1176280 is derived from MIT licensed code.  I've copied the license text and put it at the top of the file:

Here it is:

+// The monster regexp we're using is derived from Diego Perini's code,
+// currently available at https://gist.github.com/dperini/729294
+//
+// So, we'll put this file under that license (we may later wish to extract
+// the regexp to its own module, but that probably wants to wait until we
+// have some sort of bundler for the standalone client so that we don't saddle
+// standalone users with yet another file to download).
+
+// Regular Expression for URL validation
+//
+// Original Author: Diego Perini
+// License: MIT
+//
+// Copyright (c) 2010-2013 Diego Perini (http://www.iport.it)
+//
+// Permission is hereby granted, free of charge, to any person
+// obtaining a copy of this software and associated documentation
+// files (the "Software"), to deal in the Software without
+// restriction, including without limitation the rights to use,
+// copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the
+// Software is furnished to do so, subject to the following
+// conditions:
+//
+// The above copyright notice and this permission notice shall be
+// included in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+// OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+// HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+// WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+// OTHER DEALINGS IN THE SOFTWARE.
+//

The automated tests for this code are derived in part from the automated tests for Autolinker.js, also under the MIT license:

+/*
+ * Many of these tests are ported from Autolinker.js:
+ *
+ * https://github.com/gregjacobs/Autolinker.js/blob/master/tests/AutolinkerSpec.js
+ *
+ * which is released under the MIT license.  Thanks to Greg Jacobs for his hard
+ * work there.
+ *
+ * The MIT License (MIT)
+ * Original Work Copyright (c) 2014 Gregory Jacobs (http://greg-jacobs.com)
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * "Software"), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to the
+ * following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included
+ * in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
Flags: qe-verify-
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
Gerv, can you sign off on adding two files with this licensing into the tree?
Flags: needinfo?(gerv)
Isn't the idea with clearly stated MPL compatible licenses, like MIT, that we don't need to ask for clearance? I'm just saying to - perhaps - unburden Gerv a bit here and in the future...
Mike: it's always good to check; sometimes people add extra clauses or tweak things and it causes problems. :-)

r=gerv for these two licenses; assuming this code is going into Firefox, please add them to about:license (toolkit/content/license.html) as "URL Validation Regexp License" and "Autolinker.js License". Usual thing: alphabetical order, etc. Get me to rubber-stamp the patch.

Gerv
Flags: needinfo?(gerv)
(Assignee)

Comment 4

3 years ago
OK, I'll ask you for an rs in bug 1176280.
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.