Closed
Bug 1186243
Opened 9 years ago
Closed 9 years ago
android l10n repacks try to run setup.sh
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
Details
Attachments
(1 file, 2 obsolete files)
13.64 KB,
patch
|
jlund
:
review+
|
Details | Diff | Splinter Review |
Now that setup.sh is gone from bug 1182407, we should stop trying to run it in android single-locale repacks.
Assignee | ||
Comment 1•9 years ago
|
||
I'm not quite sure how to handle the branches now that mozharness is in m-c. I went ahead and removed it in all of them, though if we port this to build/mozharness, I suspect we'd just want to remove it in the mozilla-central configs since other branches still have setup.sh in the tooltool manifests. Thoughts?
Attachment #8636844 -
Flags: review?(jlund)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8636844 [details] [diff] [review] bootstrapcmd Actually this failed try (hazard builds and a single b2g emulator build). I should have a new patch up soon.
Attachment #8636844 -
Flags: review?(jlund)
Assignee | ||
Comment 3•9 years ago
|
||
This one seems to work: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2c8d48db5eb I also did a staging android-api-11 l10n build, which seemed to work.
Attachment #8636844 -
Attachment is obsolete: true
Attachment #8637465 -
Flags: review?(jlund)
Comment 4•9 years ago
|
||
Comment on attachment 8637465 [details] [diff] [review] 0001-Bug-1186243-Remove-references-to-setup.sh.patch Review of attachment 8637465 [details] [diff] [review]: ----------------------------------------------------------------- looks good but we decided over irc to just update the central configs and then update aurora on next uplift (like we would if mh was out of tree). The only reason we decided to do that this time is in case we need to backout gecko-mozharness. In the future it would be nice to use the benefits we gain from having mozharness in-tree by letting entire patches like this ride the trains and just do the right thing.
Attachment #8637465 -
Flags: review?(jlund) → review-
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8637465 -
Attachment is obsolete: true
Attachment #8638028 -
Flags: review?(jlund)
Updated•9 years ago
|
Attachment #8638028 -
Flags: review?(jlund) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•