1186278 - Regression: Some doorhangers have round-corner-looking artifacts

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Rounding in the middle of a doorhanger

For longer site identity doorhangers, the rounded corners seem to be appearing in the middle of a doorhanger.

This is on a Nightly from 7/21.

The site identity doorhanger changes size frequently, depending on the security of the page. This could be as simple as re-drawing whenever site identity updates; if this is a big perf hit, we could try to be clever about when the doorhanger size/contents change.

Comment 1

[:Margaret Leibovic]

Martyn, this is on you :)

Comment 2

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e355207bcd33

Comment 3

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret

Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret

Comment 4

[:Margaret Leibovic]

Comment on attachment 8639883 [details]
MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret

This feels a bit out of my Android league, so my review here would just be a rubber stamp. Let's ask Sebastian to take a look as well to make sure there's nothing I'm missing.

Comment 5

[:Margaret Leibovic]

Comment on attachment 8639883 [details]
MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret

https://reviewboard.mozilla.org/r/14185/#review12939

Ship It!

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8639883 [details]
MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret

Nice!

I was wondering if we could move the creation of the mask bitmap to onLayout() entirely. It seems to work in my tests but I'm not 100% sure if the measured size of the view will always match the canvas size. Moving this to onLayout() would remove the boolean and one condition from onDraw. But yeah, it's a micro-optimization, so r+. :)

Comment 7

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92b65649abd5

Comment 8

[Martyn Haigh (:mhaigh)]

url:        https://hg.mozilla.org/integration/fx-team/rev/90922d258d627ab32fad50be611219258fab7611
changeset:  90922d258d627ab32fad50be611219258fab7611
user:       Martyn Haigh <[e-mail]>
date:       Wed Aug 05 15:34:21 2015 +0100
description:
Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r=sebastian

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90922d258d62