Closed
Bug 1186278
Opened 10 years ago
Closed 10 years ago
Regression: Some doorhangers have round-corner-looking artifacts
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox42 fixed, fennec42+)
RESOLVED
FIXED
Firefox 42
People
(Reporter: liuche, Assigned: mhaigh)
References
Details
Attachments
(2 files)
For longer site identity doorhangers, the rounded corners seem to be appearing in the middle of a doorhanger.
This is on a Nightly from 7/21.
The site identity doorhanger changes size frequently, depending on the security of the page. This could be as simple as re-drawing whenever site identity updates; if this is a big perf hit, we could try to be clever about when the doorhanger size/contents change.
Updated•10 years ago
|
tracking-fennec: --- → ?
Updated•10 years ago
|
tracking-fennec: ? → 42+
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret
Attachment #8639883 -
Flags: review?(margaret.leibovic)
Comment 4•10 years ago
|
||
Comment on attachment 8639883 [details]
MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret
This feels a bit out of my Android league, so my review here would just be a rubber stamp. Let's ask Sebastian to take a look as well to make sure there's nothing I'm missing.
Attachment #8639883 -
Flags: review?(margaret.leibovic) → review?(s.kaspari)
Comment 5•10 years ago
|
||
Comment on attachment 8639883 [details]
MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret
https://reviewboard.mozilla.org/r/14185/#review12939
Ship It!
Attachment #8639883 -
Flags: review+
Comment 6•10 years ago
|
||
Comment on attachment 8639883 [details]
MozReview Request: Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r?margaret
Nice!
I was wondering if we could move the creation of the mask bitmap to onLayout() entirely. It seems to work in my tests but I'm not 100% sure if the measured size of the view will always match the canvas size. Moving this to onLayout() would remove the boolean and one condition from onDraw. But yeah, it's a micro-optimization, so r+. :)
Attachment #8639883 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/90922d258d627ab32fad50be611219258fab7611
changeset: 90922d258d627ab32fad50be611219258fab7611
user: Martyn Haigh <mhaigh@mozilla.org>
date: Wed Aug 05 15:34:21 2015 +0100
description:
Bug 1186278 - Regression: Some doorhangers have round-corner-looking artifacts; r=sebastian
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•