Missing max width for search suggestions on about:home and about:newtab

ASSIGNED
Assigned to

Status

()

Firefox
Search
ASSIGNED
2 years ago
2 years ago

People

(Reporter: Alexander Ploner, Assigned: nhnt11)

Tracking

42 Branch
Points:
---

Firefox Tracking Flags

(firefox42 affected)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8636912 [details]
a very long search suggestion

Steps to reproduce:
1. Open about:home or about:newtab in Firefox Nightly (here: 2015-07-21).
2. Type a very long search term into the search input that is longer than the input field itself.
3. Press the search button or the enter key so that the input gets added to the search suggestions.
4. Go back to about:home/about:newtab and type the beginning of the previously entered search term so that it appears within the suggestions below.

Expected result:
Because the suggested search term is longer than the input field, the suggestion should be cut off.

Actual result:
The suggestions box grows according to the suggestions length. This breaks the design and does not correspond to the search bars behavior.


(It could be intended behavior, but the visual design looks like it wasn't.)
(Assignee)

Comment 1

2 years ago
Thanks for filing this.
Just wanted to note here that this bug exists in the old UI as well. We probably want to truncate long suggestions with an ellipsis. Stephen, can you confirm?
Flags: needinfo?(shorlander)

Updated

2 years ago
Duplicate of this bug: 1188782
(In reply to Nihanth Subramanya [:nhnt11] from comment #1)
> We probably want to truncate long suggestions with an ellipsis.

Yes, that's what the search bar suggestion panel does.

Actually, we probably don't want to have the panel expend at all based on the size of the text content. Having it expand dynamically could cause interesting complications with the layout of the one-off engine icons when these were previously displayed on more than one line.

Comment 4

2 years ago
Created attachment 8648441 [details]
A very long search term.png
(Assignee)

Comment 5

2 years ago
Created attachment 8711866 [details] [diff] [review]
WIP

This WIP mostly fixes the bug, but the width of the suggestions list sub-table is off by 2px for some reason, and I don't yet know the reason for needing to subtract 22px from the input box's width when setting the width of the table.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(shorlander)
You need to log in before you can comment on or make changes to this bug.