Closed
Bug 1186299
Opened 9 years ago
Closed 9 years ago
Consolidate AudioSink::PrepareToShutdown and AudioSink::Shutdown into one function
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
3.38 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
Since AudioSink::Shutdown is a sync function, it looks like we can move the code of AudioSink::PrepareToShutdown into AudioSink::Shutdown. Is there any reason for the 2-step shutdown for AudioSink?
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(kinetik)
Comment 1•9 years ago
|
||
The only reason is that it used to be that the caller needed to hold the decoder monitor for AudioSink::PrepareToShutdown and drop it for Shutdown because of potential reentrancy issues caused by nsIThread::Shutdown spinning the event loop inside AudioSink::Shutdown.
Flags: needinfo?(kinetik)
Assignee | ||
Comment 2•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae00fee3eb1d
Assignee | ||
Comment 3•9 years ago
|
||
This should do the work. AudioSink::Shutdown would exit the monitor internally when necessary. AudioSink's API is also made more consistent for these functions are either thread-safe or requiring decoder monitor.
Updated•9 years ago
|
Attachment #8637108 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks for the review!
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3091363baf70
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•