Closed Bug 1186339 Opened 8 years ago Closed 8 years ago

IPv6 sockets try to connect to IPv4 TCP STUN servers

Categories

(Core :: WebRTC: Networking, defect, P1)

Product:
Core
Component:
WebRTC: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: drno, Assigned: drno)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MozReview Request: Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r=bwc
40 bytes, text/x-review-board-request
bwc
: review+
Details 
      No description provided.
Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r?bwc
Attachment #8637054 - Flags: review?(docfaraday)
Comment on attachment 8637054 [details]
MozReview Request: Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r=bwc

https://reviewboard.mozilla.org/r/13791/#review12409

::: media/mtransport/third_party/nICEr/src/net/nr_socket_multi_tcp.c:179
(Diff revision 1)
> +      r_log(LOG_ICE,LOG_INFO,"%s:%d function %s skipping STUN with different IP version (%d) than local socket (%d),",__FILE__,__LINE__,__FUNCTION__,stun_server->u.addr.ip_version,addr->ip_version);

|ip_version| is a UCHAR, so we should probably use %u here.
Attachment #8637054 - Flags: review?(docfaraday) → review+
(In reply to Byron Campen [:bwc] from comment #2)
> ::: media/mtransport/third_party/nICEr/src/net/nr_socket_multi_tcp.c:179
> (Diff revision 1)
> > +      r_log(LOG_ICE,LOG_INFO,"%s:%d function %s skipping STUN with different IP version (%d) than local socket (%d),",__FILE__,__LINE__,__FUNCTION__,stun_server->u.addr.ip_version,addr->ip_version);
> 
> |ip_version| is a UCHAR, so we should probably use %u here.

Thanks.

Should I "fix" the source of log line then as well ?
https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/ice/ice_candidate.c#558

:-)
Sure, why not.
Rank: 15
Priority: -- → P1
Comment on attachment 8637054 [details]
MozReview Request: Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r=bwc

Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r=bwc
Attachment #8637054 - Attachment description: MozReview Request: Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r?bwc → MozReview Request: Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r=bwc
Attachment #8637054 - Flags: review+ → review?(docfaraday)
Comment on attachment 8637054 [details]
MozReview Request: Bug 1186339: skip STUN/TURN servers with non-matching IP versions for TCP sockets. r=bwc

https://reviewboard.mozilla.org/r/13791/#review12523

Ship It!
Attachment #8637054 - Flags: review?(docfaraday) → review+
Try run looks good.
Keywords: checkin-needed
backlog: --- → webRTC+
https://hg.mozilla.org/mozilla-central/rev/19ce448b1c41
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Blocks: 1190720
You need to log in before you can comment on or make changes to this bug.