Long press on content editable area and got a JS type error in app_text_selection_dialog.js

RESOLVED FIXED in Firefox OS master

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

unspecified
FxOS-S4 (07Aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-master fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The new app_text_selection_dialog.js might have this issue as well.

+++ This bug was initially created as a clone of Bug #1186313 +++

When I try to long press on a content editable area, I got this error message:
GeckoConsole: [JavaScript Error: "TypeError: this.elements is undefined" {file: "app://system.gaiamobile.org/js/text_selection_dialog.js" line: 415}

Therefore, I cannot see the cut/copy/paste dialog after I select "copy image"/"copy link" on browser_context_menu from other apps. This only happens after I restart the flame. If the dialog appears once, everything looks good to me.
Created attachment 8639671 [details] [review]
[gaia] aethanyc:bug1186347 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8639671 - Flags: review?(timdream)
(Assignee)

Updated

3 years ago
Assignee: nobody → tlin
Attachment #8639671 - Flags: review?(timdream) → review+
(Assignee)

Comment 2

3 years ago
Comment on attachment 8639671 [details] [review]
[gaia] aethanyc:bug1186347 > mozilla-b2g:master

Hi Tim, 

I add two more commits to my PR. Please review them again. Thank you.
Attachment #8639671 - Flags: review+ → review?(timdream)
Attachment #8639671 - Flags: review?(timdream) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/7691b3761b6c2684f2d1e84e47fc124b375c76ab
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.