Clean up zamboni mkt/webapps/query.py

RESOLVED FIXED in 2015-10-06

Status

Marketplace
Code Quality
P4
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mat, Assigned: mat)

Tracking

2015-10-06
Points:
---

Details

(Assignee)

Description

3 years ago
In zamboni, mkt/webapps/query.py contains IndexQuerySet, IndexQuery, IndexCompiler.

- IndexQuerySet appear to be useless nowadays, we use that class in webapps and versions but never actually use its methods (with_index() and fetch_missed()).
- IndexQuery and IndexCompiler are only used by the translations app, so we should probably move that code in mkt/translations/query.py

Updated

3 years ago
Priority: -- → P4
(Assignee)

Comment 1

3 years ago
Bumped into this again while implementing bug 1208099 because of the way IndexQuerySet and ManagerBase.get_queryset() are implemented. Doing that cleanup will unblock me without having to do weird hacks.
Assignee: nobody → mpillard
Blocks: 1208099
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Fixed in https://github.com/mozilla/zamboni/commit/cd5b91972aa1c9a0b7782128df9f168aaa3d5cb5

QA:
- Please test the whole Marketplace extensively :) In particular, posting an app with translations and making sure those translations appear depending on the language set in the client, once the app is published.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-10-06

Comment 3

3 years ago
Cannot test the bug right now because of https://bugzilla.mozilla.org/show_bug.cgi?id=1203489
You need to log in before you can comment on or make changes to this bug.