Closed Bug 1186401 Opened 9 years ago Closed 9 years ago

Clean up zamboni mkt/webapps/query.py

Categories

(Marketplace Graveyard :: Code Quality, defect, P4)

Product:
Marketplace Graveyard
Component:
Code Quality
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2015-10-06

People

(Reporter: mat, Assigned: mat)

References

Details

In zamboni, mkt/webapps/query.py contains IndexQuerySet, IndexQuery, IndexCompiler. - IndexQuerySet appear to be useless nowadays, we use that class in webapps and versions but never actually use its methods (with_index() and fetch_missed()). - IndexQuery and IndexCompiler are only used by the translations app, so we should probably move that code in mkt/translations/query.py
Priority: -- → P4
Bumped into this again while implementing bug 1208099 because of the way IndexQuerySet and ManagerBase.get_queryset() are implemented. Doing that cleanup will unblock me without having to do weird hacks.
Assignee: nobody → mpillard
Blocks: 1208099
Status: NEW → ASSIGNED
Fixed in https://github.com/mozilla/zamboni/commit/cd5b91972aa1c9a0b7782128df9f168aaa3d5cb5 QA: - Please test the whole Marketplace extensively :) In particular, posting an app with translations and making sure those translations appear depending on the language set in the client, once the app is published.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-10-06
Cannot test the bug right now because of https://bugzilla.mozilla.org/show_bug.cgi?id=1203489
You need to log in before you can comment on or make changes to this bug.