Closed Bug 1186402 Opened 10 years ago Closed 9 years ago

balrog throws ISE 500 when fileUrl is null

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Unassigned, Mentored)

Details

18:07:29 INFO - "HEAD /api/releases/Fennec-mozilla-central-nightly-20150721030212 HTTP/1.1" 200 0 18:07:29 INFO - Balrog request to https://aus4-admin-dev.allizom.org/api/releases/Fennec-mozilla-central-nightly-20150721030212/builds/Android_arm-eabi-gcc3/et 18:07:29 INFO - Data sent: {'product': u'Fennec', 'hashFunction': u'sha512', 'alias': 'null', 'schema_version': 4, 'data_version': '3', 'copyTo': '["Fennec-mozilla-central-nightly-latest"]', 'version': u'42.0a1', 'data': '{"buildID": "20150721030212", "platformVersion": "42.0a1", "displayVersion": "42.0a1", "appVersion": "42.0a1", "completes": [{"fileUrl": null, "hashValue": "bc2a694cb97d239466d8df136748f11e01e0fbfdd5f5644e7cd031ef37080e225e4f1ac59492ea66e369e766bd02eff8b61afba1bf87243297cd362b954f3b06", "from": "*", "filesize": 42223616}]}'} 18:07:30 INFO - "PUT /api/releases/Fennec-mozilla-central-nightly-20150721030212/builds/Android_arm-eabi-gcc3/et HTTP/1.1" 500 541 18:07:30 INFO - Caught HTTPError: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> 18:07:30 INFO - <html><head> 18:07:30 INFO - <title>500 Internal Server Error</title> 18:07:30 INFO - </head><body> 18:07:30 INFO - <h1>Internal Server Error</h1> 18:07:30 INFO - <p>The server encountered an internal error or 18:07:30 INFO - misconfiguration and was unable to complete 18:07:30 INFO - your request.</p> 18:07:30 INFO - <p>Please contact the server administrator, 18:07:30 INFO - webmaster@mozilla.com and inform them of the time the error occurred, 18:07:30 INFO - and anything you might have done that may have 18:07:30 INFO - caused the error.</p> 18:07:30 INFO - <p>More information about this error may be available 18:07:30 INFO - in the server error log.</p> 18:07:30 INFO - </body></html> 18:07:30 INFO - Traceback (most recent call last): We should be throwing a 400 for this instead. I suspect that we're getting a traceback when trying to urlparse None, but I haven't confirmed that.
Mentor: bhearsum
Hi, I can't repeat this output. my json file is here: http://paste.ubuntu.com/15678130/ when I changed "fileUrl: null", I always get HTTP 400. my output: http://imgur.com/50syyze How can I repeat this error?
Oh! I think this bug must've been fixed when jsonschemas were implemented (bug 703040...so it's not a problem anymore. Sorry for the time you spent on it :(. Ping me on IRC and we'll find a better first bug.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.