1186469 - The 'f' key shortcut used to activate the filter field breaks Alt+f (file-menu key combo)

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit any site, e.g. https://www.mozilla.org/en-US/ , and hit "Alt+f".
     --> Browser's File menu opens. (At least, it does for me, on Linux.)

 2. Now, visit https://treeherder.mozilla.org/ and hit Alt+f

ACTUAL RESULTS:
Treeherder intercepts the key combination and activates its "Filter" field. (This is also what happens if I just press "f".)

EXPECTED RESULTS:
Browser's File menu should open.


STR #2:
 1. Visit https://treeherder.mozilla.org/ and press Ctrl+F.
  --> Find-in-page opens.
 2. Hit "Esc" key.

ACTUAL RESULTS: TreeHerder's "filter" field is active once I leave the browser's find-in-page UI.

EXPECTED RESULTS: "filter" shouldn't be activated by Ctrl+f, Esc.

Bottom line:
============
I think Treeherder is just listening for "f" keypresses, and not paying attention to whether there were modifier keys along with the "f". It should check if there were modifier keys, and ignore any such keypresses. Ctrl+f / Alt+f should be considered different signals from "f".

Comment 1

[Daniel Holbert [:dholbert]]

(Sorry, disregard mentions of Ctrl+f / find-in-page & my "STR #2" above. The ACTUAL RESULTS there only happen if the filter field was focused before Find-in-page was activated -- and that makes sense.

So, this is only a problem with Alt+f, AFAICT.)

Comment 2

[Jonathan French (:jfrench)]

I can repro this also on Windows using an old PC keyboard with a real Alt key. If I use an Apple keyboard (where 'alt' is available via shift+option) I can't, the browser's File menu comes up fine. Similarly on OSX, Cmd/Meta, Option, Option/Alt appear to be fine and are ignored and only 'f' opens the quick filter.

Comment 3

[Jonathan French (:jfrench)]

Oh, interesting. On Google Chrome, where Alt+f opens their 'hamburger' control settings, it works perfectly when sitting on https://treeherder.mozilla.org
https://support.google.com/chrome/answer/157179?hl=en > Google Chrome Feature Shortcuts > Windows,Linux

Daniel can you try that to confirm also?

Comment 4

[Daniel Holbert [:dholbert]]

Yup, I can confirm that -- this isn't reproducible in Chrome.

(That might just be because Chrome is more vigilant than Firefox is about preventing web pages from stealing its keybindings. At least, bug 380637 is marked "parity-chrome")

Comment 5

[Daniel Holbert [:dholbert]]

(Yeah, bug 1052569 comment 0 says "Other browsers like Chrome do not allow web pages to override [certain reserved keyboard shortcuts]".  A web page tested mainly in Chrome may accidentally break these shortcuts in Firefox without the developer realizing it.  This seems to be happening regularly in the wild.

So, comparison to Chrome here isn't really useful, other than as further confirmation that we should try to do something about bug 380637 / bug 1052569.)

Comment 6

[Jonathan French (:jfrench)]

Ok thanks Daniel. I'll defer to someone on the treeherder team with access to a decent development Linux/Win machine to investigate a fix. The PC I repro'd it on is >10yr old and barely runs :) If you can indicate how severe you feel the bug is, we can set a Priority relative to our other bugs in the queue.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I can probably take this.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Fun. Testing this in release builds of Firefox, I can reproduce comment 0's problem. It doesn't reproduce for me against Nightly... (Maybe some e10s issue with keyboard events?)

Comment 9

[Daniel Holbert [:dholbert]]

Yup, it seems this only reproduces if e10s is disabled. (Just double-checked locally w/ nightly + fresh profile.)

Comment 10

[Jonathan French (:jfrench)]

That would be consistent with what I saw reproducing it on my old PC. I just had release installed there, but not Nightly.

Comment 11

[Alex [:moijes12]]

Daniel

I could not reproduce this on my windows laptop. I tried this on Chrome as well as Firefox. In both cases, it opened the correct Browser menu.

Comment 12

[Daniel Holbert [:dholbert]]

Yup, this opens the browser menu now as-expected. Likely this was fixed at some point since filing, whether on the Firefox or TreeHerder side. Thanks!