Closed Bug 1186498 Opened 4 years ago Closed 4 years ago

"cached" of transferredSize in netmonitor cannot be localized

Categories

(DevTools :: Netmonitor, defect, minor)

40 Branch
defect
Not set
minor

Tracking

(firefox39 unaffected, firefox40- wontfix, firefox41 wontfix, firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox39 --- unaffected
firefox40 - wontfix
firefox41 --- wontfix
firefox42 --- fixed

People

(Reporter: yfdyh000, Assigned: yfdyh000)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Attached patch patch v1Splinter Review
Assignee: nobody → yfdyh000
Status: NEW → ASSIGNED
Attachment #8642369 - Flags: review?(jsantell)
[Tracking Requested - why for this release]:
Sorry but this is too late for 40...
Comment on attachment 8642369 [details] [diff] [review]
patch v1

Review of attachment 8642369 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Yang -- thank you for the patch!
Attachment #8642369 - Flags: review?(jsantell) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ee3ba67281f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8642369 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: bug 764958
[User impact if declined]: a English string maybe shows to non-English developers.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low, just a new string.
[String/UUID change made/needed]: a new string.
Attachment #8642369 - Flags: approval-mozilla-aurora?
Axel, can you take a look at this patch? I've been told to run any string changes by you before I approve. Can you please comment if you have any concerns on the patch? Thanks.
Flags: needinfo?(l10n)
TBH, I don't do approvals, relman does, and should fight back on string changes.

"Just a string in devtools" isn't a strong rationale in my book, so I wouldn't take this.

Also, http://hg.mozilla.org/mozilla-central/rev/e2edbf7a4634 says this is on since April, can't be all that bad.
Flags: needinfo?(l10n)
I appreciate your thoughts on these matters which is why I asked. I agree that RelMan makes a final call.

I think your observation is correct that this issue has been in two past releases so it can easily ride the trains.
Comment on attachment 8642369 [details] [diff] [review]
patch v1

We typically do not take string changes during Aurora and Beta cycle. Also, given that we have lived with this issue for two releases, we can just let this one ride the trains. 

Also note this fix which is in FF42 will be on Aurora channel in a week.
Attachment #8642369 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Okay, I understand, thank you all.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.