1186498 - "cached" of transferredSize in netmonitor cannot be localized

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[YF (Yang)]

http://hg.mozilla.org/mozilla-central/annotate/e7434cafdf2f/browser/devtools/netmonitor/netmonitor-view.js#l1669

Comment 1

[YF (Yang)]

Attachment: patch v1

Comment 2

[YF (Yang)]

[Tracking Requested - why for this release]:

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Sorry but this is too late for 40...

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8642369 [details] [diff] [review]
patch v1

Review of attachment 8642369 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Yang -- thank you for the patch!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2ee3ba67281f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ee3ba67281f

Comment 7

[YF (Yang)]

Comment on attachment 8642369 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: bug 764958
[User impact if declined]: a English string maybe shows to non-English developers.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low, just a new string.
[String/UUID change made/needed]: a new string.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Axel, can you take a look at this patch? I've been told to run any string changes by you before I approve. Can you please comment if you have any concerns on the patch? Thanks.

Comment 9

[Axel Hecht [:Pike]]

TBH, I don't do approvals, relman does, and should fight back on string changes.

"Just a string in devtools" isn't a strong rationale in my book, so I wouldn't take this.

Also, http://hg.mozilla.org/mozilla-central/rev/e2edbf7a4634 says this is on since April, can't be all that bad.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I appreciate your thoughts on these matters which is why I asked. I agree that RelMan makes a final call.

I think your observation is correct that this issue has been in two past releases so it can easily ride the trains.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8642369 [details] [diff] [review]
patch v1

We typically do not take string changes during Aurora and Beta cycle. Also, given that we have lived with this issue for two releases, we can just let this one ride the trains. 

Also note this fix which is in FF42 will be on Aurora channel in a week.

Comment 12

[YF (Yang)]

Okay, I understand, thank you all.