Closed Bug 1186541 Opened 10 years ago Closed 10 years ago

StandaloneRoomView.shouldRenderRemoteVideo: unexpected roomState: room-gather

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla42
Iteration:
42.2 - Jul 27
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: pdehaan, Assigned: standard8)

Details

Attachments

(1 file)

Fix a warning in StandaloneRoomView.shouldRenderRemoteVideo when the roomState is gather.
3.94 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review
Using FF40. Was doing a call with the handsome Mr :rpapa and saw this error float by in my dev tools console: > StandaloneRoomView.shouldRenderRemoteVideo: unexpected roomState: room-gather > standaloneRoomViews.js:413: Which is roughly https://github.com/mozilla/loop-client/blob/2b2c696eb524fd4428724c08c85c3ad91d724f41/content/js/standaloneRoomViews.jsx#L390 (not sure why the line number mis-match, but maybe they repos are out of sync).
This fixes the warning, there's no harm to it as the default is the same.
Attachment #8637417 - Flags: review?(mdeboer)
Assignee: nobody → standard8
Iteration: --- → 42.2 - Jul 27
Points: --- → 1
Comment on attachment 8637417 [details] [diff] [review] Fix a warning in StandaloneRoomView.shouldRenderRemoteVideo when the roomState is gather. Review of attachment 8637417 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8637417 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/24d4e869eec9
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: