1186544 - A better test suite for StructuredCloneAlgorithm

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: test.patch

The idea of this test is to support any clonable/transferring object in any context.
Currently it supports:

1. window-to-window
2. window-to-iframe
3. window-to-cross-origin-iframe

I'll update the patches of any sub-issue of bug 972973 in order to extend this test.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Why not testharness.js? This sounds extremely useful for Servo as well.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: test.patch

Here we test messageport too.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8638587 [details] [diff] [review]
test.patch

Otherwise looking good, but RCTCertificate handling would be still possibly thread-unsafe.
Could you fix that and then file a followup to sort out how RCTCertificate should behave when one tries to receive it on workers.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: test.patch

No needs to throw an exception manually because if the Write/Read functions return null/false, the error callback will be used.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8639372 [details] [diff] [review]
test.patch

And please file a followup for each if (!NS_IsMainThread()) { case in the Read.

And perhaps those MOZ_ASSERTs could have some message that it isn't a critical bug, but someone is trying to use an unsupported feature.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

One thing to think about - GC/CC after message has been sent but before it has been receiced. 
That might prevent certain types of regressions.
No need to do in this bug.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03bb7cc89e2c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03bb7cc89e2c