The default bug view has changed. See this FAQ.

mReadOnly and mDisabled do not reflect readOnly and disabled properties

RESOLVED FIXED in 4.0.2

Status

Calendar
Provider: CalDAV
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.2
Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
See bug 674088 for details:

"""
Then, I looked at the "minor error" code, this is obviously not a minor error. I've noticed that changing mReadOnly and mDisabled does not actually change the properties "readOnly" and "disabled". I've fixed this by removing mDisabled and mReadOnly and just using the property getters directly.
"""
(Assignee)

Comment 1

2 years ago
Created attachment 8637361 [details] [diff] [review]
Fix - v1

r+ from the other bug
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8637361 - Flags: review+
(Assignee)

Updated

2 years ago
Attachment #8637361 - Flags: approval-calendar-release+
Attachment #8637361 - Flags: approval-calendar-beta+
Attachment #8637361 - Flags: approval-calendar-aurora+
(Assignee)

Comment 2

2 years ago
Backported to releases/comm-aurora changeset c53da8a616fa
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.3
(Assignee)

Comment 3

2 years ago
Backported to releases/comm-beta changeset 18d4427d4203
Target Milestone: 4.3 → 4.2
(Assignee)

Comment 4

2 years ago
Backported to releases/comm-esr38 changeset 59bfcc074820
Target Milestone: 4.2 → 4.0.2
(Assignee)

Comment 5

2 years ago
Backported to releases/comm-aurora changeset 3638ae3dc946
Target Milestone: 4.0.2 → 4.3
(Assignee)

Comment 6

2 years ago
Backported to releases/comm-beta changeset 3a6adf92dcac
Target Milestone: 4.3 → 4.2
(Assignee)

Comment 7

2 years ago
Backported to releases/comm-esr38 changeset e08fb68b3474
Target Milestone: 4.2 → 4.0.2

Comment 8

2 years ago
This still needs to be checked in to cc - setting checkin-needed for this.
Blocks: 1180416
Keywords: checkin-needed

Comment 9

2 years ago
This patch is bitrotted for cc when applyied on top of the one from https://bugzilla.mozilla.org/show_bug.cgi?id=674088#c21
Whiteboard: [comm-centra]
(Assignee)

Comment 10

2 years ago
url:        https://hg.mozilla.org/comm-central/rev/bdc31ac73a9af77519a613c794cf8c7a2d989a8b
changeset:  bdc31ac73a9af77519a613c794cf8c7a2d989a8b
user:       Philipp Kewisch <mozilla@kewis.ch>
date:       Sat Aug 08 11:05:38 2015 +0100
description:
Fix bug 1186547 - mReadOnly and mDisabled do not reflect readOnly and disabled properties. r=MakeMyDay
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Whiteboard: [comm-centra]

Comment 11

2 years ago
Is the 2nd checkin from comment 6/7/8 required for comm-central too?
Flags: needinfo?(philipp)
(Assignee)

Comment 12

2 years ago
Looking at http://mxr.mozilla.org/comm-central/source/calendar/providers/caldav/calDavCalendar.js#1888 this has already happened in the patch for bug 674088. There was a bit of a mess with the push messages here.
Flags: needinfo?(philipp)

Comment 13

2 years ago
Could this be responsible for the regression reported in Bug 1195800 / Bug 1195974?
(Assignee)

Comment 14

2 years ago
Yes, quite likely. I've set bug 1195974 to be tracked for 4.0.3

Updated

2 years ago
Depends on: 1195974

Comment 15

2 years ago
Patch was backed-out from Lightning 4.5, 4.4, 4.3 and 4.0 with Bug 1195974. Follow up in Bug 1201862.
You need to log in before you can comment on or make changes to this bug.