Closed Bug 1186582 Opened 5 years ago Closed 5 years ago

nsContentPermissionUtils::AskPermission should throw on nsContentPermissionPrompt::prompt exception

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: qdot, Assigned: qdot)

Details

Attachments

(1 file)

When calling AskPermission, on desktop we call into nsBrowserGlue.js, where nsContentPermissionPrompt's prompt function is implemented. However, we don't actually check for exceptions after prompt is called, meaning that things like i18n/l10n failures just throw to stderr and are hard to discern. It'd be nice to be able to actually propagate errors so we can possibly catch prompt problems in mochitests.
Attachment #8637420 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/d9bb3467a3b2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.