1186582 - nsContentPermissionUtils::AskPermission should throw on nsContentPermissionPrompt::prompt exception

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

When calling AskPermission, on desktop we call into nsBrowserGlue.js, where nsContentPermissionPrompt's prompt function is implemented. However, we don't actually check for exceptions after prompt is called, meaning that things like i18n/l10n failures just throw to stderr and are hard to discern. It'd be nice to be able to actually propagate errors so we can possibly catch prompt problems in mochitests.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - AskPermission should check for prompt() exceptions

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9bb3467a3b2

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d9bb3467a3b2