nsContentPermissionUtils::AskPermission should throw on nsContentPermissionPrompt::prompt exception

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: qdot, Assigned: qdot)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

When calling AskPermission, on desktop we call into nsBrowserGlue.js, where nsContentPermissionPrompt's prompt function is implemented. However, we don't actually check for exceptions after prompt is called, meaning that things like i18n/l10n failures just throw to stderr and are hard to discern. It'd be nice to be able to actually propagate errors so we can possibly catch prompt problems in mochitests.
Attachment #8637420 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/d9bb3467a3b2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.