Tile title bar enhancements

RESOLVED FIXED in Firefox 43

Status

()

Firefox
New Tab Page
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Kevin Ghim, Assigned: maxim zhilyaev)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 42
Points:
2
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

(Whiteboard: [story])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Story bug for UI enhancements for tile title bar on new tab. 
- 1px outline around the edges of the title bar
- thin line on the top of the title bar
- inclusion of fav icon

Aaron, please attach spec sheet.

Comment 1

3 years ago
Created attachment 8637433 [details]
NT-URL_bar_UI_V1.pdf

Specs attached!
(Reporter)

Updated

3 years ago
Whiteboard: [story]
(Reporter)

Updated

3 years ago
Blocks: 1192057
(Reporter)

Updated

3 years ago
No longer blocks: 1176364

Updated

3 years ago
Assignee: nobody → mzhilyaev
Iteration: --- → 42.3 - Aug 10
Target Milestone: --- → Firefox 42

Comment 2

3 years ago
For the tile rollover title bar, there should be a 1 pixel white rule that separate the title bar from the tile background.
(Assignee)

Comment 3

3 years ago
title bar color changes on rollover will be handled in the bug as well.
Bug# 1188015 will be just for setting partner provided BG color.
(Assignee)

Comment 4

3 years ago
Created attachment 8648035 [details] [diff] [review]
Wrong path - ignore
Attachment #8648035 - Flags: review?(msamuel)
(Assignee)

Updated

3 years ago
Attachment #8648035 - Attachment description: v1. cosmetics → Wrong path - ignore
Attachment #8648035 - Attachment is obsolete: true
Attachment #8648035 - Flags: review?(msamuel)
(Assignee)

Comment 5

3 years ago
Created attachment 8648044 [details] [diff] [review]
v1. initial implementation
Attachment #8648044 - Flags: review?(msamuel)

Updated

3 years ago
Blocks: 1195113

Updated

3 years ago
Attachment #8648044 - Attachment is patch: true
Attachment #8648044 - Attachment mime type: text/x-patch → text/plain
Created attachment 8648795 [details]
tile_hover.png
The attached patch looks good to me. Aaron can you take a look at the two attached screenshots to confirm the styles look correct?

Note: The favicon portion of this bug is separate: bug 1158856
Flags: needinfo?(athornburgh)

Comment 9

3 years ago
Yes, these are correct. Thank you!
Flags: needinfo?(athornburgh)

Updated

3 years ago
Attachment #8648044 - Flags: review?(msamuel) → review+

Updated

3 years ago
No longer blocks: 1195113
Iteration: 42.3 - Aug 10 → 43.1 - Aug 24
(Assignee)

Updated

3 years ago
Points: --- → 2
https://hg.mozilla.org/mozilla-central/rev/af84fe5e960e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED

Updated

3 years ago
Depends on: 1197510
You need to log in before you can comment on or make changes to this bug.