Closed Bug 1186596 Opened 5 years ago Closed 5 years ago

Tile title bar enhancements

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 42
Iteration:
43.1 - Aug 24
Tracking Status
firefox42 --- affected
firefox43 --- fixed

People

(Reporter: kghim, Assigned: mzhilyaev)

References

(Blocks 1 open bug)

Details

(Whiteboard: [story])

Attachments

(4 files, 1 obsolete file)

Story bug for UI enhancements for tile title bar on new tab. 
- 1px outline around the edges of the title bar
- thin line on the top of the title bar
- inclusion of fav icon

Aaron, please attach spec sheet.
Attached file NT-URL_bar_UI_V1.pdf
Specs attached!
Whiteboard: [story]
Blocks: 1192057
No longer blocks: 1176364
Assignee: nobody → mzhilyaev
Iteration: --- → 42.3 - Aug 10
Target Milestone: --- → Firefox 42
For the tile rollover title bar, there should be a 1 pixel white rule that separate the title bar from the tile background.
title bar color changes on rollover will be handled in the bug as well.
Bug# 1188015 will be just for setting partner provided BG color.
Attached patch Wrong path - ignore (obsolete) — Splinter Review
Attachment #8648035 - Flags: review?(msamuel)
Attachment #8648035 - Attachment description: v1. cosmetics → Wrong path - ignore
Attachment #8648035 - Attachment is obsolete: true
Attachment #8648035 - Flags: review?(msamuel)
Attachment #8648044 - Flags: review?(msamuel)
Blocks: Sprint_CS_S1
Attachment #8648044 - Attachment is patch: true
Attachment #8648044 - Attachment mime type: text/x-patch → text/plain
Attached image tile.png
Attached image tile_hover.png
The attached patch looks good to me. Aaron can you take a look at the two attached screenshots to confirm the styles look correct?

Note: The favicon portion of this bug is separate: bug 1158856
Flags: needinfo?(athornburgh)
Yes, these are correct. Thank you!
Flags: needinfo?(athornburgh)
Attachment #8648044 - Flags: review?(msamuel) → review+
No longer blocks: Sprint_CS_S1
Iteration: 42.3 - Aug 10 → 43.1 - Aug 24
Points: --- → 2
Depends on: 1197510
You need to log in before you can comment on or make changes to this bug.