Remove unused LESS/JS files from page bundles

RESOLVED FIXED

Status

www.mozilla.org
Pages & Content
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jpetto, Assigned: jpetto)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1806041])

(Assignee)

Description

2 years ago
There are a (yet to be determined) number of pages on bedrock that load unused .js and .less files, either in the page specific bundles or the inherited template bundles.

Most recently noticed examples:

- jquery.waypoints.min.js on the home page

- nav-main-resp.js on /firefox/products/, /firefox/hello/, /firefox/interest-dashboard/, and likely others

- spin.min.js seems to be included on almost all pages, but is used on only a few

I'm guessing the first example is an orphaned dependency (home page used to use waypoints?), while the latter 2 are legacy common libraries inherited from a parent template.

On a related note, do we still need the mozilla-input-placeholder.js polyfill? It's included on pages throughout the site.

It would be good to do an audit to trim down page payload.
(Assignee)

Updated

2 years ago
Whiteboard: [kb=1806041]
(In reply to Jon Petto [:jpetto] from comment #0) 
> - jquery.waypoints.min.js on the home page

Interestingly I also happened to think of this just the other day. I think the homepage is still using waypoints, but it's only purpose is GA scroll tracking. The page has been up for long enough for us to have good data on it (folks we're originally worried users would not know to scroll the page). I think we should be good to remove this tracking to save on page weight.

There's also this JS file that was for an experiment on the home page, which can also likely be removed: https://github.com/mozilla/bedrock/blob/master/media/js/mozorg/home/scroll-prompt.js

Updated

2 years ago
Depends on: 1187246
Filed Bug 1187246 to discuss removing the homepage scroll tracking.
It's also worth investigating and removing template-resp.css if it's no longer being used.
(Assignee)

Updated

2 years ago
Assignee: nobody → jon

Comment 4

2 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ef5f483e9d685634985c5bd268f9bbb48efa7165
[fix bug 1186605] Audit LESS & JS bundles.

https://github.com/mozilla/bedrock/commit/b20e0b9906aa1fa13e569b9dcb0694f6a1c61703
Merge pull request #3370 from jpetto/bug-1186605-audit-less-js-bundles

[fix bug 1186605] Audit LESS & JS bundles.

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.