Closed Bug 1186647 Opened 10 years ago Closed 7 years ago

the UI for deleted binary files is unclear

Categories

(MozReview Graveyard :: General, defect, P2)

Product:
MozReview Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: keeler, Unassigned)

Details

(Whiteboard: [to be fixed in core])

I can't tell if this is because bug 1151121 hasn't been fixed or if the UI is unclear (I think it's the latter), but it's not obvious when looking at the diff view that a binary file has been deleted. See e.g. https://reviewboard.mozilla.org/r/12491/diff/3#4 It just says "This is a binary file. The content cannot be displayed.", whereas I'm expecting it to somehow indicate that it was deleted.
I'm almost certain this is a Review Board core bug. I took a quick look and the data we're generating for Review Board is being parsed and stored correctly, it looks like a bug in the templating. I'll see about tracking this down.
Assignee: nobody → smacleod
Whiteboard: [to be fixed in core]
Priority: -- → P2
Product: Developer Services → MozReview
Assignee: smacleod → nobody
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.