1186650 - Do not mark mozilla::Variant copy and move constructors as explicit

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

...as it makes it impossible to return a Variant.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Do not mark mozilla::Variant copy and move constructors as explicit

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8637482 [details] [diff] [review]
Do not mark mozilla::Variant copy and move constructors as explicit

Review of attachment 8637482 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Variant.h
@@ +295,5 @@
>      Impl::copyConstruct(ptr(), aRhs);
>    }
>  
>    /** Move construction. */
> +  Variant(Variant&& aRhs)

I think these want to be MOZ_IMPLICIT to make the treeherder gods happy.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> I think these want to be MOZ_IMPLICIT to make the treeherder gods happy.

I think that doesn't apply to move/copy ctors, just regular ctors, because there are a lot of places in the tree that don't have it.

Either way, try push to be sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=30341202fca4

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d75fa8dc080e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d75fa8dc080e