Do not mark mozilla::Variant copy and move constructors as explicit

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

...as it makes it impossible to return a Variant.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8637482 [details] [diff] [review]
Do not mark mozilla::Variant copy and move constructors as explicit

Review of attachment 8637482 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Variant.h
@@ +295,5 @@
>      Impl::copyConstruct(ptr(), aRhs);
>    }
>  
>    /** Move construction. */
> +  Variant(Variant&& aRhs)

I think these want to be MOZ_IMPLICIT to make the treeherder gods happy.
Attachment #8637482 - Flags: review?(jwalden+bmo) → review+
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> I think these want to be MOZ_IMPLICIT to make the treeherder gods happy.

I think that doesn't apply to move/copy ctors, just regular ctors, because there are a lot of places in the tree that don't have it.

Either way, try push to be sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=30341202fca4
https://hg.mozilla.org/mozilla-central/rev/d75fa8dc080e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.