1186667 - Correctly report IMAGE_DECODE_COUNT and IMAGE_MAX_DECODE_COUNT telemetry for non-size decodes

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

In bug 1119774 I accidentally flipped the sense of a boolean check that determined whether we recorded IMAGE_DECODE_COUNT and IMAGE_MAX_DECODE_COUNT telemetry. Previously, we were supposed to record that telemetry only for non-size decodes. The bug made it so that we only record that telemetry for size decodes, which means that the telemetry is no longer usefully measuring redecodes at all. The regression was reported in bug 1126307 but nobody had a chance to investigate at the time.

We noticed the root cause of the issue in bug 1184996. Let's get it fixed!

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Correctly report IMAGE_DECODE_COUNT and IMAGE_MAX_DECODE_COUNT telemetry for only non-size decodes

Here's the patch. It just moves the telemetry code up into the previous |if| condition.

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69bee90b0abc

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69bee90b0abc