Closed Bug 1186690 Opened 10 years ago Closed 7 years ago

Linter should run only on the index (files being committed) and when rebasing

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: hub, Unassigned)

Details

We run the linter on a gaia commit. But it is run on the whole changeset rather than just the index (files to be committed). Also it should run when rebasing as a rebase apparently caused a linter error...
Above I meant "on the whole *diff* rather than just the index"
You might be able to do some kind of pre-rebase hook, though in this case we probably just want to check test results of gaia-try, and bring back autolander to prevent us from burning the tree.
I have to admit I'm guilty of having ignored the gaia-try as I was eager to land this.
Actually we use "git diff --staged" (which is synonym to --cached). So we actually run it on the index only. About rebase: there is the hook pre-rebase we could try to use. But sometimes it's painful because sometimes we want to ignore the hook when we want to commit quickly something ("git commit -n" does this) and afaik there is no way to do this with rebase. But in the end, the authoritative source of greenness is gaia-try. There isn't a good reason to ignore gaia-try these days, as it is quite quick.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.