Closed
Bug 1186693
Opened 9 years ago
Closed 9 years ago
Add exhaustive matching to mozilla::Variant
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.37 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
So we can get compile time checking that we handle every case.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8637533 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9dd1cbf5f9
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8637533 [details] [diff] [review] Add exhaustive matching to mozilla::Variant Review of attachment 8637533 [details] [diff] [review]: ----------------------------------------------------------------- Kinda purty. Also kinda horrifying, but purty still. My, the weather *is* so nice this time of year in Stockholm, isn't it?
Attachment #8637533 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8637533 -
Attachment is obsolete: true
Attachment #8645215 -
Flags: review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
It turns out msvc doesn't like auto/decltype returns. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d60f29e9f2ec
|
||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b40bed41a511
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•