Add exhaustive matching to mozilla::Variant

RESOLVED FIXED in Firefox 42

Status

()

Core
MFBT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

So we can get compile time checking that we handle every case.
Created attachment 8637533 [details] [diff] [review]
Add exhaustive matching to mozilla::Variant
Attachment #8637533 - Flags: review?(jwalden+bmo)
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Blocks: 1139476

Comment 3

3 years ago
Comment on attachment 8637533 [details] [diff] [review]
Add exhaustive matching to mozilla::Variant

Review of attachment 8637533 [details] [diff] [review]:
-----------------------------------------------------------------

Kinda purty.  Also kinda horrifying, but purty still.

My, the weather *is* so nice this time of year in Stockholm, isn't it?
Attachment #8637533 - Flags: review?(jwalden+bmo) → review+
Blocks: 1187062
Created attachment 8645215 [details] [diff] [review]
Add exhaustive matching to mozilla::Variant
Attachment #8637533 - Attachment is obsolete: true
Attachment #8645215 - Flags: review+
It turns out msvc doesn't like auto/decltype returns.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d60f29e9f2ec
https://hg.mozilla.org/mozilla-central/rev/b40bed41a511
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.