Closed Bug 1186693 Opened 4 years ago Closed 4 years ago

Add exhaustive matching to mozilla::Variant

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

So we can get compile time checking that we handle every case.
Attachment #8637533 - Flags: review?(jwalden+bmo)
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8637533 [details] [diff] [review]
Add exhaustive matching to mozilla::Variant

Review of attachment 8637533 [details] [diff] [review]:
-----------------------------------------------------------------

Kinda purty.  Also kinda horrifying, but purty still.

My, the weather *is* so nice this time of year in Stockholm, isn't it?
Attachment #8637533 - Flags: review?(jwalden+bmo) → review+
It turns out msvc doesn't like auto/decltype returns.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d60f29e9f2ec
https://hg.mozilla.org/mozilla-central/rev/b40bed41a511
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.