Closed
Bug 1186709
Opened 9 years ago
Closed 9 years ago
Remove MOZ_IMPLICIT from imported Chromium sandbox source
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jld, Assigned: jld)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.06 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
Now that bug 1183485 has landed, we can remove the MOZ_IMPLICIT additions to security/sandbox/chromium and thereby reduce our divergence from upstream. It's already passed Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4eba80eccb55
Attachment #8637570 -
Flags: review?(bobowen.code)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8637570 [details] [diff] [review] Patch: remove MOZ_IMPLICIT from security/sandbox/chromium Review of attachment 8637570 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Jed.
Attachment #8637570 -
Flags: review?(bobowen.code) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
Update commit message to make life easier when landing this; carrying over r+.
Attachment #8637570 -
Attachment is obsolete: true
Attachment #8637951 -
Flags: review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
checkin-needed note: the other patches in https://treeherder.mozilla.org/#/jobs?repo=try&revision=4eba80eccb55 have landed, so that run should be equivalent to Try-ing this patch alone atop m-c.
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c6858eaf1b2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•