1186783 - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Because iterators are so much nicer than enumerate functions.

There are 11 occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).

Comment 1

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Attachment: (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/

Comment 2

[Michal Novotny [:michal]]

Comment on attachment 8682826 [details] [diff] [review]
(part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/

Review of attachment 8682826 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/streamconv/nsStreamConverterService.cpp
@@ +219,5 @@
>  
>      // Create a corresponding color table for each vertex in the graph.
>      BFSHashTable lBFSTable;
> +    for (auto iter = mAdjacencyList.Iter(); !iter.Done(); iter.Next()) {
> +        const nsACString &aKey = iter.Key();

Please change the variable name (e.g. to key) to not confuse it with argument.

Comment 3

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3654304318e11e2e0ef8775678ae22e314623e6e
Bug 1186783 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/. r=michal.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3654304318e1

Comment 5

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Attachment: (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators

Comment 6

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Attachment: (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators

Comment 7

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Attachment: (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators

Comment 8

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Attachment: (part 4) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators

Comment 9

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

Attachment: (part 5) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators

Comment 10

[Patrick McManus [:mcmanus]]

I'm fine with these in principal - I'm just stuck with not being able to look at the closely before the holiday and pto wave kicks in.. I'll delegate them to valentin.. thanks!

Comment 11

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9045a2712a76bc2d048fcbb462e6395885b0fb1
Bug 1186783 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1f87a9a1795973a6ffa80625b52a725726ea59c
Bug 1186783 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/788287eae76366afd74bc7a817682bbf2cfd6f8c
Bug 1186783 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a53d7747369c6d4fc12fd89e2cdb8c2c2195725b
Bug 1186783 (part 4) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/149337c2aa8970ada0aaa78c124d085007db0127
Bug 1186783 (part 5) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.

Comment 12

[Nicholas Nethercote [:njn] (PTO Dec 23 - Jan 28)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8a6449cb4edd1f7e13b232085ad7d1c07e2d86
Bug 1186783 (follow-up) - Bustage fix for Gonk.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f9045a2712a7
https://hg.mozilla.org/mozilla-central/rev/d1f87a9a1795
https://hg.mozilla.org/mozilla-central/rev/788287eae763
https://hg.mozilla.org/mozilla-central/rev/a53d7747369c
https://hg.mozilla.org/mozilla-central/rev/149337c2aa89
https://hg.mozilla.org/mozilla-central/rev/8d8a6449cb4e