Closed
Bug 1186783
Opened 7 years ago
Closed 7 years ago
Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(5 files, 1 obsolete file)
5.62 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
2.98 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
4.65 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
4.24 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
3.30 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
Because iterators are so much nicer than enumerate functions. There are 11 occurrences of EnumerateRead() in this directory. A note to the assignee: to preserve existing behaviour, you should probably use nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
![]() |
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8682826 -
Flags: review?(michal.novotny)
![]() |
Assignee | |
Updated•7 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
Comment on attachment 8682826 [details] [diff] [review] (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ Review of attachment 8682826 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/streamconv/nsStreamConverterService.cpp @@ +219,5 @@ > > // Create a corresponding color table for each vertex in the graph. > BFSHashTable lBFSTable; > + for (auto iter = mAdjacencyList.Iter(); !iter.Done(); iter.Next()) { > + const nsACString &aKey = iter.Key(); Please change the variable name (e.g. to key) to not confuse it with argument.
Attachment #8682826 -
Flags: review?(michal.novotny) → review+
![]() |
Assignee | |
Updated•7 years ago
|
Keywords: leave-open
![]() |
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3654304318e11e2e0ef8775678ae22e314623e6e Bug 1186783 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/. r=michal.
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3654304318e1
![]() |
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8689825 -
Flags: review?(mcmanus)
![]() |
Assignee | |
Updated•7 years ago
|
Attachment #8682826 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 6•7 years ago
|
||
Attachment #8689826 -
Flags: review?(mcmanus)
![]() |
Assignee | |
Comment 7•7 years ago
|
||
Attachment #8689827 -
Flags: review?(mcmanus)
![]() |
Assignee | |
Comment 8•7 years ago
|
||
Attachment #8689828 -
Flags: review?(mcmanus)
![]() |
Assignee | |
Comment 9•7 years ago
|
||
Attachment #8689829 -
Flags: review?(mcmanus)
Updated•7 years ago
|
Attachment #8689825 -
Flags: review?(mcmanus) → review?(valentin.gosu)
Updated•7 years ago
|
Attachment #8689826 -
Flags: review?(mcmanus) → review?(valentin.gosu)
Updated•7 years ago
|
Attachment #8689827 -
Flags: review?(mcmanus) → review?(valentin.gosu)
Updated•7 years ago
|
Attachment #8689828 -
Flags: review?(mcmanus) → review?(valentin.gosu)
Updated•7 years ago
|
Attachment #8689829 -
Flags: review?(mcmanus) → review?(valentin.gosu)
Comment 10•7 years ago
|
||
I'm fine with these in principal - I'm just stuck with not being able to look at the closely before the holiday and pto wave kicks in.. I'll delegate them to valentin.. thanks!
Updated•7 years ago
|
Attachment #8689826 -
Flags: review?(valentin.gosu) → review+
Updated•7 years ago
|
Attachment #8689825 -
Flags: review?(valentin.gosu) → review+
Updated•7 years ago
|
Attachment #8689827 -
Flags: review?(valentin.gosu) → review+
Updated•7 years ago
|
Attachment #8689829 -
Flags: review?(valentin.gosu) → review+
Updated•7 years ago
|
Attachment #8689828 -
Flags: review?(valentin.gosu) → review+
![]() |
Assignee | |
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9045a2712a76bc2d048fcbb462e6395885b0fb1 Bug 1186783 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin. https://hg.mozilla.org/integration/mozilla-inbound/rev/d1f87a9a1795973a6ffa80625b52a725726ea59c Bug 1186783 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin. https://hg.mozilla.org/integration/mozilla-inbound/rev/788287eae76366afd74bc7a817682bbf2cfd6f8c Bug 1186783 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin. https://hg.mozilla.org/integration/mozilla-inbound/rev/a53d7747369c6d4fc12fd89e2cdb8c2c2195725b Bug 1186783 (part 4) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin. https://hg.mozilla.org/integration/mozilla-inbound/rev/149337c2aa8970ada0aaa78c124d085007db0127 Bug 1186783 (part 5) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.
![]() |
Assignee | |
Updated•7 years ago
|
Keywords: leave-open
![]() |
Assignee | |
Comment 12•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8a6449cb4edd1f7e13b232085ad7d1c07e2d86 Bug 1186783 (follow-up) - Bustage fix for Gonk.
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f9045a2712a7 https://hg.mozilla.org/mozilla-central/rev/d1f87a9a1795 https://hg.mozilla.org/mozilla-central/rev/788287eae763 https://hg.mozilla.org/mozilla-central/rev/a53d7747369c https://hg.mozilla.org/mozilla-central/rev/149337c2aa89 https://hg.mozilla.org/mozilla-central/rev/8d8a6449cb4e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•