1186786 - Replace nsBaseHashtable::EnumerateRead() calls in accessible/ with iterators

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Nicholas Nethercote [inactive]]

+++ This bug was initially created as a clone of Bug #1186785 +++

Because iterators are so much nicer than enumerate functions.

There are four occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Replace nsBaseHashtable::EnumerateRead() calls in accessible/ with iterators

I added a comment about the unusual nature of DocManager::ClearDocCache().
Please let me know if I misunderstood how it works.

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8675977 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in accessible/ with iterators

I guess it may be possible to cleanup the document shutdown handling and maybe some of the null checking, but this all seems correct.

sorry about the lag.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a1e89df904b953006be78880dbe99ad262c5d6a
Bug 1186786 - Replace nsBaseHashtable::EnumerateRead() calls in accessible/ with iterators. r=tbsaunde.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a1e89df904b