Closed
Bug 1186792
Opened 6 years ago
Closed 5 years ago
Replace nsBaseHashtable::EnumerateRead() calls in hal/ with iterators
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Core
Hardware Abstraction Layer (HAL)
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
4.08 KB,
patch
|
dhylands
:
review+
|
Details | Diff | Splinter Review |
Because iterators are so much nicer than enumerate functions. There are three occurrences of EnumerateRead() in this directory. A note to the assignee: to preserve existing behaviour, you should probably use nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #8676020 -
Flags: review?(dhylands)
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
||
Comment 2•5 years ago
|
||
Comment on attachment 8676020 [details] [diff] [review] Replace nsBaseHashtable::EnumerateRead() calls in hal/ with iterators Review of attachment 8676020 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8676020 -
Flags: review?(dhylands) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee3dd50843ae3fb5bb849abacc7dfc46b6139b4 Bug 1186792 - Replace nsBaseHashtable::EnumerateRead() calls in hal/ with iterators. r=dhylands.
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ee3dd50843a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•