11868 - Setting readonly attr to true doesn't work for input=text

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[rods (gone)]

Attachment: Test setting readonly to true

Comment 1

[rods (gone)]

The test case attached here relies on Bug #11620 being fixed, I have the fix in
my tree.

Comment 2

[buster]

I think this is fixed from the text control's point of view.  Rod, can you
please retest with a version of the file picker that works?

Comment 3

[rods (gone)]

I am executing these lines:

  if (nsHTMLAtoms::disabled == aAttribute) {
    nsAutoString val(nsFormFrame::GetDisabled(this) ? "true":"false");
    mTextContent->SetAttribute(kNameSpaceID_None, nsHTMLAtoms::readonly, val,
PR_TRUE);
  }

and it still doesn't go back to r/w, I can't click in it.

Comment 4

[buster]

The text control frame code is correct.  I've fixed the file upload control
frame, so it's correct now too.
According to peterl, this is Hyatt's bug now.  He's changing the semantics of
"AttributeChanged" notifications so the frame always gets called when an HTML
attribute is changed.  Once this work is done, this bug will go away on it's
own.

Comment 5

[David Hyatt]

My checkin just landed.  Try it now.

Comment 6

[buster]

fixed.

Comment 7

[gerardok]

QA Contact massive update.

Comment 8

[Vladimir Ermakov]

Verifying
  Windows 98 build 2000-09-19-05-M18
  Linux RedHat6.2 build 2000-09-19-21-M18