Closed
Bug 1186800
Opened 9 years ago
Closed 9 years ago
Hardware composer cannot get the correct display size of an external display.
Categories
(Core Graveyard :: Widget: Gonk, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1186000
People
(Reporter: kuoe0.tw, Assigned: kuoe0.tw)
References
Details
Attachments
(1 file, 1 obsolete file)
9.33 KB,
patch
|
Details | Diff | Splinter Review |
In HwcHAL::GetHwcAttributes(), this function only query the primary display to get the size of dispaly frame. It causes the multi-screen feature to not render the frame on the external display.
Comment 1•9 years ago
|
||
This is what it's supposed to be. [1] https://hg.mozilla.org/mozilla-central/file/fed42e7cad94/widget/gonk/HwcComposer2D.cpp#l833
Comment 2•9 years ago
|
||
display size is already handled by nsScreenGonk. Therefore, HwcHAL::GetHwcAttributes() is redundant implementation. In bug 1186000, wip patch already remove HwcHAL::GetHwcAttributes().
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #2) > display size is already handled by nsScreenGonk. Therefore, > HwcHAL::GetHwcAttributes() is redundant implementation. In bug 1186000, wip > patch already remove HwcHAL::GetHwcAttributes(). Hi Sotaro, I want to add a parameter of nsScreenGonk to HwcHAL::Prepare() and HwcHAL::Set(). Do you think that is a good idea?
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kuoe0
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
> Hi Sotaro, I want to add a parameter of nsScreenGonk to HwcHAL::Prepare() > and HwcHAL::Set(). Do you think that is a good idea? Yea, it is good idea. Sorry, my post attachment 8637902 [details] [diff] [review] crossed your post. attachment 8637902 [details] [diff] [review] is just snippet from bug 1186000.
Updated•9 years ago
|
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8637902 -
Attachment is obsolete: true
Assignee | ||
Comment 8•9 years ago
|
||
I mentioned about the cropped result (see the attachment) in Bug 1186000 comment #32. I found the problem is not caused by Android or Gecko. It caused by the overscan feature[1] of displays. Most HDMI devices are defaulted to turn on the overscan feature. So we have to set the display to use 1:1 pixel mapping to make it work properly. Some displays have two mode, PC mode and AV mode. The AC mode default to turn on the overscan feature, and PC mode doesn't. I found bug 1186000 is landed. So maybe we can flag this bug to RESOLVED DUPLICATE with bug 1186000. [1]: https://en.wikipedia.org/wiki/Overscan?oldformat=true
Flags: needinfo?(sotaro.ikeda.g)
Comment 9•9 years ago
|
||
Thanks.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(sotaro.ikeda.g)
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•