1186806 - Replace nsBaseHashtable::EnumerateRead() calls in dom/html/ with iterators

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are five occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).

Comment 1

[Biru [:poiru]]

Attachment: Part 1: Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLFormControlsCollection

Comment 2

[Biru [:poiru]]

Attachment: Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLFormElement

Comment 3

[Biru [:poiru]]

Attachment: Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLMediaElement

Comment 4

[Biru [:poiru]]

Attachment: Part 4: Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLPropertiesCollection

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8638345 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLFormElement

Review of attachment 8638345 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLFormElement.cpp
@@ +141,5 @@
>    NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mPastNameLookupTable)
> +  for (auto iter = tmp->mSelectedRadioButtons.Iter(); !iter.Done();
> +       iter.Next()) {
> +    cb.NoteXPCOMChild(ToSupports(iter.UserData()));
> +  }

Can this just use NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mSelectedRadioButtons)?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8638345 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLFormElement

Review of attachment 8638345 [details] [diff] [review]:
-----------------------------------------------------------------

Perhaps an r- will elicit a response to my question :D

Comment 7

[Biru [:poiru]]

Attachment: Part 2: Use NS_IMPL_CYCLE_COLLECTION_TRAVERSE instead of manual traversal in HTMLFormElement

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> Comment on attachment 8638345 [details] [diff] [review]
> Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLFormElement
> 
> Review of attachment 8638345 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/html/HTMLFormElement.cpp
> @@ +141,5 @@
> >    NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mPastNameLookupTable)
> > +  for (auto iter = tmp->mSelectedRadioButtons.Iter(); !iter.Done();
> > +       iter.Next()) {
> > +    cb.NoteXPCOMChild(ToSupports(iter.UserData()));
> > +  }
> 
> Can this just use NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mSelectedRadioButtons)?

I assumed the manual traversal was there for a reason, but seems like it's just from ancient times. Sorry for the delay!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbc6ff3a0290
https://hg.mozilla.org/integration/mozilla-inbound/rev/60cb17f179ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/5608fa9939d2
https://hg.mozilla.org/integration/mozilla-inbound/rev/2696ce503d33

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bbc6ff3a0290
https://hg.mozilla.org/mozilla-central/rev/60cb17f179ef
https://hg.mozilla.org/mozilla-central/rev/5608fa9939d2
https://hg.mozilla.org/mozilla-central/rev/2696ce503d33