Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Because iterators are so much nicer than enumerate functions.

There are three occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
(Assignee)

Comment 1

3 years ago
Created attachment 8686859 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators
Attachment #8686859 - Flags: review?(bugzilla)
(Assignee)

Updated

3 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Fixed two small compile errors.
Attachment #8686964 - Flags: review?(bugzilla)
(Assignee)

Updated

3 years ago
Attachment #8686859 - Attachment is obsolete: true
Attachment #8686859 - Flags: review?(bugzilla)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Review of attachment 8686964 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try a different reviewer.
Attachment #8686964 - Flags: review?(bugzilla) → review?(aosmond)
Comment on attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

LGTM. Much simpler :).
Attachment #8686964 - Flags: review?(aosmond) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/58c11f8db0b1e70cdc941c79ddf216e6436a8afe
Bug 1186808 - Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators. r=mikeh.

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/58c11f8db0b1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.