Closed Bug 1186808 Opened 7 years ago Closed 6 years ago

Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file, 1 obsolete file)

Because iterators are so much nicer than enumerate functions.

There are three occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Fixed two small compile errors.
Attachment #8686964 - Flags: review?(bugzilla)
Attachment #8686859 - Attachment is obsolete: true
Attachment #8686859 - Flags: review?(bugzilla)
Comment on attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Review of attachment 8686964 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try a different reviewer.
Attachment #8686964 - Flags: review?(bugzilla) → review?(aosmond)
Comment on attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

LGTM. Much simpler :).
Attachment #8686964 - Flags: review?(aosmond) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/58c11f8db0b1e70cdc941c79ddf216e6436a8afe
Bug 1186808 - Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators. r=mikeh.
https://hg.mozilla.org/mozilla-central/rev/58c11f8db0b1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.