1186808 - Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are three occurrences of EnumerateRead() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Fixed two small compile errors.

Comment 3

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7acc8d4f8842

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

Review of attachment 8686964 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try a different reviewer.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8686964 [details] [diff] [review]
Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators

LGTM. Much simpler :).

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58c11f8db0b1e70cdc941c79ddf216e6436a8afe
Bug 1186808 - Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators. r=mikeh.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58c11f8db0b1