1186812 - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/ with iterators

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are four occurrences of EnumerateRead() in these directories.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8681762 [details] [diff] [review]
(part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/

Review of attachment 8681762 [details] [diff] [review]:
-----------------------------------------------------------------

nice.

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/173b5e1ba6014e5d55579cd3c182be604b714172
Bug 1186812 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/982d153e3ce6befe885bf9b6c2912acf2af125bd
Bug 1186812 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c273256b3e07b1b7c1a1b039d65dcbc9862c9cd8
Bug 1186812 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/. r=jimm.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/173b5e1ba601
https://hg.mozilla.org/mozilla-central/rev/982d153e3ce6
https://hg.mozilla.org/mozilla-central/rev/c273256b3e07

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/173b5e1ba601
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/982d153e3ce6
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/c273256b3e07