Closed Bug 1186812 Opened 4 years ago Closed 4 years ago

Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/ with iterators

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(3 files, 1 obsolete file)

Because iterators are so much nicer than enumerate functions.

There are four occurrences of EnumerateRead() in these directories.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Attachment #8681760 - Attachment is obsolete: true
Attachment #8681760 - Flags: review?(jmathies)
Comment on attachment 8681762 [details] [diff] [review]
(part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/

Review of attachment 8681762 [details] [diff] [review]:
-----------------------------------------------------------------

nice.
Attachment #8681762 - Flags: review?(jmathies) → review+
Attachment #8681763 - Flags: review?(jmathies) → review+
Attachment #8681764 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/173b5e1ba6014e5d55579cd3c182be604b714172
Bug 1186812 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/982d153e3ce6befe885bf9b6c2912acf2af125bd
Bug 1186812 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c273256b3e07b1b7c1a1b039d65dcbc9862c9cd8
Bug 1186812 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in dom/{ipc,plugins}/. r=jimm.
https://hg.mozilla.org/mozilla-central/rev/173b5e1ba601
https://hg.mozilla.org/mozilla-central/rev/982d153e3ce6
https://hg.mozilla.org/mozilla-central/rev/c273256b3e07
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.