Closed
Bug 1186814
Opened 9 years ago
Closed 9 years ago
Replace nsBaseHashtable::EnumerateRead() calls in extensions/spellcheck/ with iterators
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
2.45 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Because iterators are so much nicer than enumerate functions. There is one occurrence of EnumerateRead() in this directory. A note to the assignee: to preserve existing behaviour, you should probably use nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8676033 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
||
Updated•9 years ago
|
Attachment #8676033 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/44904f46bc865b5a6272842e520252171ea4e404 Bug 1186814 - Replace nsBaseHashtable::EnumerateRead() calls in extensions/spellcheck/ with iterators. r=ehsan.
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/44904f46bc86
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•