Closed
Bug 1186815
Opened 9 years ago
Closed 9 years ago
Replace nsBaseHashtable::EnumerateRead() calls in modules/libjar/ with iterators
Categories
(Core :: Networking: JAR, defect)
Core
Networking: JAR
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files, 4 obsolete files)
|
2.60 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
|
3.34 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
Because iterators are so much nicer than enumerate functions. There are four occurrences of EnumerateRead() in this directory. A note to the assignee: to preserve existing behaviour, you should probably use nsBaseHashtable::Iterator::UserData() rather than nsBaseHashtable::Iterator::Data(). (The latter should be used when replacing nsBaseHashtable::Enumerate()).
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8679175 -
Flags: review?(mwu)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8679180 -
Flags: review?(mwu)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Fixed the log message to refer to the right directory.
Attachment #8679191 -
Flags: review?(mwu)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8679175 -
Attachment is obsolete: true
Attachment #8679175 -
Flags: review?(mwu)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8679192 -
Flags: review?(mwu)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8679180 -
Attachment is obsolete: true
Attachment #8679180 -
Flags: review?(mwu)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8679259 -
Flags: review?(n.nethercote)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Attachment #8679260 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8679259 [details] [diff] [review] (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in dom/base/ with iterators (uploaded patch to the wrong bug)
Attachment #8679259 -
Attachment is obsolete: true
Attachment #8679259 -
Flags: review?(n.nethercote)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Comment on attachment 8679260 [details] [diff] [review] (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in dom/base/ with iterators (uploaded patch to the wrong bug)
Attachment #8679260 -
Attachment is obsolete: true
Attachment #8679260 -
Flags: review?(khuey)
|
||
Updated•9 years ago
|
Attachment #8679191 -
Flags: review?(mwu) → review+
|
|
||
Updated•9 years ago
|
Attachment #8679192 -
Flags: review?(mwu) → review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff0e32d96b6c01cafc6ebf2bb68772b0fceaa3a1 Bug 1186815 (part 1) - Replace nsBaseHashtable::Enumerate() calls in modules/libjar/ with iterators. r=mwu. https://hg.mozilla.org/integration/mozilla-inbound/rev/e903447ff321014cca5a95ef4aff6b84c318fa0b Bug 1186815 (part 2) - Replace nsBaseHashtable::Enumerate() calls in modules/libjar/ with iterators. r=mwu.
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ff0e32d96b6c https://hg.mozilla.org/mozilla-central/rev/e903447ff321
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•