Last Comment Bug 1186828 - Support gtk3 builds
: Support gtk3 builds
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: 4.4
Assigned To: Philipp Kewisch [:Fallen]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-23 01:27 PDT by Philipp Kewisch [:Fallen]
Modified: 2015-07-27 05:35 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix - v1 (650 bytes, patch)
2015-07-23 01:28 PDT, Philipp Kewisch [:Fallen]
mohit.kanwal: review+
Details | Diff | Splinter Review
Unbitrotted GTK changes [Checked in: Comment 6] (1000 bytes, patch)
2015-07-26 11:15 PDT, Ian Neal
philipp: review+
Details | Diff | Splinter Review

Description User image Philipp Kewisch [:Fallen] 2015-07-23 01:27:17 PDT

    
Comment 1 User image Philipp Kewisch [:Fallen] 2015-07-23 01:28:18 PDT
Created attachment 8637759 [details] [diff] [review]
Fix - v1
Comment 2 User image Mohit Kanwal [:redDragon] 2015-07-23 07:01:28 PDT
Comment on attachment 8637759 [details] [diff] [review]
Fix - v1

Review of attachment 8637759 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Does it build successfully? Tinderbox?
Comment 3 User image Ian Neal 2015-07-26 11:15:22 PDT
Created attachment 8639043 [details] [diff] [review]
Unbitrotted GTK changes [Checked in: Comment 6]

This got bitrotted, so here is a revised version.
Comment 4 User image Philipp Kewisch [:Fallen] 2015-07-27 01:03:46 PDT
Comment on attachment 8639043 [details] [diff] [review]
Unbitrotted GTK changes [Checked in: Comment 6]

Thanks for the update. Do we still need gtk in there? I don't think gecko still builds with gtk 1 support?
Comment 5 User image Philipp Kewisch [:Fallen] 2015-07-27 01:09:27 PDT
(In reply to Mohit Kanwal [:redDragon] from comment #2)
> LGTM. Does it build successfully? Tinderbox?

Pretty sure this will build successful, since it is only adding and removing a value to/from the list
Comment 6 User image Ian Neal 2015-07-27 03:55:22 PDT
Comment on attachment 8639043 [details] [diff] [review]
Unbitrotted GTK changes [Checked in: Comment 6]

Checked in with unneeded gtk argument removed:
https://hg.mozilla.org/comm-central/rev/ae01190864a8

Note You need to log in before you can comment on or make changes to this bug.