Status

Calendar
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8637759 [details] [diff] [review]
Fix - v1
Attachment #8637759 - Flags: review?(mohit.kanwal)
Comment on attachment 8637759 [details] [diff] [review]
Fix - v1

Review of attachment 8637759 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Does it build successfully? Tinderbox?
Attachment #8637759 - Flags: review?(mohit.kanwal) → review+

Comment 3

2 years ago
Created attachment 8639043 [details] [diff] [review]
Unbitrotted GTK changes [Checked in: Comment 6]

This got bitrotted, so here is a revised version.
Attachment #8639043 - Flags: review?(philipp)
(Assignee)

Updated

2 years ago
Attachment #8637759 - Attachment is obsolete: true
(Assignee)

Comment 4

2 years ago
Comment on attachment 8639043 [details] [diff] [review]
Unbitrotted GTK changes [Checked in: Comment 6]

Thanks for the update. Do we still need gtk in there? I don't think gecko still builds with gtk 1 support?
Attachment #8639043 - Flags: review?(philipp) → review+
(Assignee)

Comment 5

2 years ago
(In reply to Mohit Kanwal [:redDragon] from comment #2)
> LGTM. Does it build successfully? Tinderbox?

Pretty sure this will build successful, since it is only adding and removing a value to/from the list

Updated

2 years ago
OS: Unspecified → All
Hardware: Unspecified → All

Comment 6

2 years ago
Comment on attachment 8639043 [details] [diff] [review]
Unbitrotted GTK changes [Checked in: Comment 6]

Checked in with unneeded gtk argument removed:
https://hg.mozilla.org/comm-central/rev/ae01190864a8
Attachment #8639043 - Attachment description: Unbitrotted GTK changes → Unbitrotted GTK changes [Checked in: Comment 6]

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.2

Updated

2 years ago
Target Milestone: 4.2 → 4.4
You need to log in before you can comment on or make changes to this bug.