On B2G, let MP4Decoder handle 3GPP files.

RESOLVED FIXED in Firefox 43

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jolin, Assigned: jolin)

Tracking

Trunk
mozilla43
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Part of work to deprecate Media(Omx|Codec)Decoder per discussion with :bwu.
Also make fixing bug 1159343 easier because 3GPP files (recorded by Camera app) and MP4 files currently use different decoder and both have seeking problem. :)
(Assignee)

Comment 1

3 years ago
Created attachment 8637803 [details] [diff] [review]
Let MP4Decoder handle 3GPP files on B2G.

Returns true for 3GPP files in MP4Decoder::HandleMediaType() when Gonk PDM is available.
Attachment #8637803 - Flags: review?(cpearce)
Comment on attachment 8637803 [details] [diff] [review]
Let MP4Decoder handle 3GPP files on B2G.

Review of attachment 8637803 [details] [diff] [review]:
-----------------------------------------------------------------

I assume our demuxer and the Gonk PDM can handle 3GPP?
Attachment #8637803 - Flags: review?(cpearce) → review+
(In reply to John Lin [:jolin][:jhlin] from comment #0)
> Part of work to deprecate Media(Omx|Codec)Decoder per discussion with :bwu.
Yeah! After syncing with cpearce via irc two weeks ago?, the goal is to use MediaFormatReader for all the formats if possible. So we should deprecate MediaOmxReader and MediaCodecReader.
(Assignee)

Comment 4

3 years ago
Created attachment 8648666 [details] [diff] [review]
Let MP4Decoder handle 3GPP files on B2G.

Carry r+ from cpearce.
Attachment #8637803 - Attachment is obsolete: true
Attachment #8648666 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/1d3817f7fff6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.