./mach update-uuids is broken from the recent IDL Parser changes

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: RyanVM, Assigned: new_one)

Tracking

Trunk
mozilla42

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
ryanvm@ubuntu:~/repos/mozilla-inbound$ ./mach update-uuids nsIAudioChannelAgent
Error running mach:

    ['update-uuids', 'nsIAudioChannelAgent']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'module' object has no attribute 'IDLParser'

  File "/home/ryanvm/repos/mozilla-inbound/tools/mach_commands.py", line 183, in update_uuids
    parser = xpidl.IDLParser(outputdir=tmpdir)
Flags: needinfo?(peter.elmers)
(Assignee)

Comment 1

3 years ago
Created attachment 8637934 [details] [diff] [review]
Fix import statements for mach update-uuids

Updated two import statements in mach_commands to the new path of the xpidl module. Grepped for any other "import xpidl" in the code base and found none outside the idl-parser itself.
Attachment #8637934 - Flags: review?(ryanvm)
(Assignee)

Updated

3 years ago
Assignee: nobody → peter.elmers
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Flags: needinfo?(peter.elmers)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8637934 [details] [diff] [review]
Fix import statements for mach update-uuids

I'm not a peer of this code.
Attachment #8637934 - Flags: review?(ryanvm) → review?(gps)

Comment 3

3 years ago
Comment on attachment 8637934 [details] [diff] [review]
Fix import statements for mach update-uuids

Review of attachment 8637934 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing!
Attachment #8637934 - Flags: review?(gps) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Gregory Szorc [:gps] from comment #3)
> Comment on attachment 8637934 [details] [diff] [review]
> Fix import statements for mach update-uuids
> 
> Review of attachment 8637934 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for fixing!

Thanks for review! Should I run any tests, or is this ready for check in?

Comment 5

3 years ago
(In reply to Peter Elmers [:new_one] from comment #4)
> Thanks for review! Should I run any tests, or is this ready for check in?

Please use needinfo! I almost missed this and only got to it just now because I'm behind on non-flagged bugmail.

As long as it works locally, this is good for checkin.
(Assignee)

Comment 6

3 years ago
Ah, will use needinfo next time! The fix does work locally.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Reporter)

Comment 8

3 years ago
https://hg.mozilla.org/mozilla-central/rev/992a26539e87
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.