1186896 - ./mach update-uuids is broken from the recent IDL Parser changes

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

ryanvm@ubuntu:~/repos/mozilla-inbound$ ./mach update-uuids nsIAudioChannelAgent
Error running mach:

    ['update-uuids', 'nsIAudioChannelAgent']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'module' object has no attribute 'IDLParser'

  File "/home/ryanvm/repos/mozilla-inbound/tools/mach_commands.py", line 183, in update_uuids
    parser = xpidl.IDLParser(outputdir=tmpdir)

Comment 1

[Peter Elmers [:new_one]]

Attachment: Fix import statements for mach update-uuids

Updated two import statements in mach_commands to the new path of the xpidl module. Grepped for any other "import xpidl" in the code base and found none outside the idl-parser itself.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8637934 [details] [diff] [review]
Fix import statements for mach update-uuids

I'm not a peer of this code.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8637934 [details] [diff] [review]
Fix import statements for mach update-uuids

Review of attachment 8637934 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing!

Comment 4

[Peter Elmers [:new_one]]

(In reply to Gregory Szorc [:gps] from comment #3)
> Comment on attachment 8637934 [details] [diff] [review]
> Fix import statements for mach update-uuids
> 
> Review of attachment 8637934 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for fixing!

Thanks for review! Should I run any tests, or is this ready for check in?

Comment 5

[Gregory Szorc [:gps]]

(In reply to Peter Elmers [:new_one] from comment #4)
> Thanks for review! Should I run any tests, or is this ready for check in?

Please use needinfo! I almost missed this and only got to it just now because I'm behind on non-flagged bugmail.

As long as it works locally, this is good for checkin.

Comment 6

[Peter Elmers [:new_one]]

Ah, will use needinfo next time! The fix does work locally.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/992a26539e87

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/992a26539e87