1186909 - Use eTLD+1 rather than host for the history query lookup for nsIPermissionManager migrations

Status: RESOLVED FIXED

(Core :: Permission Manager, defect)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Use eTLD+1 rather than host for the history query lookup for nsIPermissionManager migrations

Comment 2

[(no longer active)]

Comment on attachment 8637923 [details] [diff] [review]
Use eTLD+1 rather than host for the history query lookup for nsIPermissionManager migrations

Review of attachment 8637923 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/nsPermissionManager.cpp
@@ +343,5 @@
> +      rv = tldService->GetBaseDomainFromHost(aHost, 0, eTLD1);
> +      NS_ENSURE_SUCCESS(rv, rv);
> +    } else {
> +      NS_WARNING("Should have a tld service!");
> +      eTLD1 = aHost;

This is technically incorrect, but there is no reason why the do_GetService() call above should fail, since this code cannot be called during shutdown, so r=me.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

(In reply to Ehsan Akhgari (not reviewing patches, not reading bugmail, needinfo? me!) from comment #2)
> This is technically incorrect, but there is no reason why the
> do_GetService() call above should fail, since this code cannot be called
> during shutdown, so r=me.

After bug 1185239 I'm just defensively guarding against services being unavailable I think :).

Would you like me to MOZ_ASSERT(tldService) instead?

Comment 4

[(no longer active)]

Instead, no.  In addition to, yes please!

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Use eTLD+1 rather than host for the history query lookup for nsIPermissionManager migrations

Updated version with a MOZ_ASSERT().

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c86f53d8b66

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c86f53d8b66