Closed Bug 1186926 Opened 9 years ago Closed 8 years ago

lightyear.fm WebGL crash (TypeError: Argument 2 of WebGLRenderingContext.attachShader does not implement interface WebGLShader)

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

defect
Not set
normal

Tracking

(firefox39 affected, firefox40 affected, firefox41 affected, firefox42 affected, fennec+)

RESOLVED WORKSFORME
Tracking Status
firefox39 --- affected
firefox40 --- affected
firefox41 --- affected
firefox42 --- affected
fennec + ---

People

(Reporter: miketaylr, Assigned: jgilbert)

References

Details

(Keywords: crash, regression)

Crash Data

STR:

1) go to http://lightyear.fm/
2) ignore mobile warning, click "try it anyway"
3) let it site there and load a bunch of assets then click Play (can take a while)
4) once playing, click down the year scale on the top left

Expected: It skips ahead
Actual: Crash.

logcat output @ https://github.com/webcompat/web-bugs/issues/1458#issuecomment-124138174.

It seems like it fall over here: 
E/GeckoConsole(22240): [JavaScript Error: "TypeError: Argument 2 of WebGLRenderingContext.attachShader does not implement interface WebGLShader." {file: "http://lightyear.fm/js_ly/build/production.min.js" line: 11}]
tracking-fennec: --- → ?
Reproduced with my Sony Z3 phone running Android 5.0.2 with today's Nightly. Currently there are 3 reports of this crash against Fennec 42.0a1 and 2 reports against Fennec 41.0a2.
Crash Signature: [@ mozilla::gl::SharedSurface_EGLImage::~SharedSurface_EGLImage] [@ @0x0 | mozilla::gl::SharedSurface_EGLImage::~SharedSurface_EGLImage]
Keywords: crash
It looks like this is a regression since I can't reproduce this with Fennec 39 and 40. I'll see if I can track down a regression window.
> Does webcompat.com report the Firefox version used to report the bug?

Yeah, it captures the full UA string (in addition to trying to guess via the ua parsing lib we used server side)--hidden as an html comment (you can view-source). In this case though, it's not very helpful.

The reporter was using "Mozilla/5.0 (X11; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0 Iceweasel/39.0" to file the bug, so it seems they manually filled out Android 4.4.4 and Firefox 39.0.

Let me see if I can repro on Release.
I get a crash to the desktop on a Galaxy S3 with all versions of Firefox so there is no assurance that this crash is something that is caught by the Mozilla crash reporter.
I just got a crash on 39, as did Vladikoff (who happens to be in my living room right now).
With the Mozilla crash reporter dialog or crashing to the desktop? What specific phone?
With the crash reporter once, and to the desktop another time, on my OnePlus One. The reporter crash seemed to be when clicking on the timeline as mentioned in the STR while the Desktop crash was just waiting for the site to do its thing.
Mike, would you mind finding the correct regression window since you have a device handy that can reproduce this reliably?
Sure thing, was at a conf today and will be on PTO until Wednesday--so it'll be mid-next week.
ni? myself to remind me to do this.
Flags: needinfo?(miket)
Assignee: nobody → jgilbert
tracking-fennec: ? → 43+
OK, just bisected this down to: 

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c7720cbbe62e&tochange=c4d1692d88ee

This is for the crash that always has this error:

> E/GeckoConsole(22925): [JavaScript Error: "TypeError: Argument 2 of WebGLRenderingContext.attachShader does not implement interface WebGLShader." {file: "http://lightyear.fm/js_ly/build/production.min.js" line: 11}]

It seems there's sometimes another crash-to-desktop/OOM bug but I can't get that to reproduce 100% of the time.
Flags: needinfo?(miket)
Depends on: 1144906
Do you have time to investigate here?
Flags: needinfo?(jgilbert)
Yeah, I'll take a look.
Flags: needinfo?(jgilbert)
Updating title so it's easier to find.
Summary: lightyear.fm WebGL crash → lightyear.fm WebGL crash (TypeError: Argument 2 of WebGLRenderingContext.attachShader does not implement interface WebGLShader)
tracking-fennec: 43+ → +
Is this still active?
Flags: needinfo?(jgilbert)
This is working for me on my HTC One m7. Does this still repro for others?
Flags: needinfo?(snorp)
Flags: needinfo?(jgilbert)
Flags: needinfo?(anthony.s.hughes)
Seems to be fixed for me
Flags: needinfo?(snorp)
I cannot seem to reproduce this anymore either. I'm going to go ahead and call this WORKSFORME. Please reopen or revise if you think that's incorrect.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(anthony.s.hughes)
Resolution: --- → WORKSFORME
I still get a crash to the desktop on a current nightly on the Galaxy S3.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.