1186985 - Increase timeout value in wait_for_received_messages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I've know multiple times test:
tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_add_to_new_contact_from_messages.py

And sometimes (1 out of 3/4 times) I just don't get an sms back or it takes a very long time (after a restart). It really makes me wonder if there's something going wrong with self.data_layer.send_sms?

Manually sending sms-es on the device seems to work ok.

Comment 1

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #0)
> Manually sending sms-es on the device seems to work ok.

Hmm, manually sending sms-es seem to have the same issue.

Comment 2

[Martijn Wargers (dead)]

Ok, I guess this is mainly due to my sms-provider. 
I tested now on my other (Android) phone and sometimes, the sms-es are just not received until after a very long time (>3 minutes).

I propose to increase the value here from 180 to 300, because we do that at least for other places where we try to receive an sms:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/message_thread.py#22
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_notification.py#25

Comment 3

[Martijn Wargers (dead)]

Updating summary to do that.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1186985 > mozilla-b2g:master

Comment 5

[Martijn Wargers (dead)]

I also think it's not necessary to poll that often, so making the interval 5s here.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8638520 [details] [review]
[gaia] mwargers:1186985 > mozilla-b2g:master

Waiting 5 minute with 5 seconds pings is fine.

Comment 7

[No-Jun Park [:njpark]]

Comment on attachment 8638520 [details] [review]
[gaia] mwargers:1186985 > mozilla-b2g:master

LGTM.

Comment 8

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/27e47e038788dbef1fbe4b59998e7298f2f3e93c