1186991 - thclient post_collection results in "TypeError: name must be a byte string" in OpenSSL

Status: RESOLVED WORKSFORME

(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P2)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: traceback

(This is essentially a summary of a conversation with mdoglio in #treeherder)

Posting a job_collection to treeherder.allizom.org with treeherder-client==1.6 yields |TypeError("name must be a byte string")| (see 'traceback' attachment), where |name| refers to |u'treeherder.allizom.org'|.

Context:
* The requests version is 2.7.0. 
* My call to post_collection is here:  https://github.com/mjzffr/firefox-media-tests/blob/pf-jenkins-th-update/treeherding.py#L292
* The call is triggered via this mozharness script: https://github.com/mjzffr/firefox-media-tests/blob/pf-jenkins-th-update/run_media_tests.py

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: log_debug.log (mozharness)

All config options and environment info.

Comment 2

[Ed Morley [:emorley]]

This maybe seems relevant:
https://github.com/shazow/urllib3/issues/515

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I believe this issue is specific to Python 2.7.10. [1]

Verified that I can post results under 2.7.8, for example: https://treeherder.allizom.org/#/jobs?repo=mozilla-central&revision=1f77b78797d6&filter-job_group_symbol=VP

[1] Maybe relevant: "Issue #1865: ``bytes`` as an alias for ``str`` and b"" as an alias "" were
  added." (https://hg.python.org/cpython/raw-file/15c95b7d81dc/Misc/NEWS)

Comment 4

[Ed Morley [:emorley]]

Are you still seeing this? I was thinking of reporting this against the requests package - do you have any more information (OS version etc) that I can add to the report? Thanks :-)

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Not anymore: I just run the same job under Python 2.7.9 and 2.7.10, and I don't hit any errors.

Comment 6

[Ed Morley [:emorley]]

(In reply to Maja Frydrychowicz (:maja_zf) from comment #5)
> Not anymore: I just run the same job under Python 2.7.9 and 2.7.10, and I
> don't hit any errors.

Strange! Thank you for checking :-)