1186992 - Follows up repository permissions normalization

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

I found a few issues with the initial landing of the repository permissions normalization from bug 1186256.

1. By using outputif in the CRON, we don't get summaries of what actually changed unless the script exits with a non-0 exit code. I want to get output emails because I want to find processes responsible for applying bad permissions.

2. The repository root directory itself doesn't have its permissions adjusted. Although, if we start adjusting permissions outside of .hg, we need to be careful for repos that have checkouts. (There should be no repos with checkouts.)

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: ansible/hg-web: remove outputif from permissions cron (bug 1186992); r?fubar

ansible/hg-web: remove outputif from permissions cron (bug 1186992); r?fubar

We want to receive email reports of what changed so we can identify
processes that are mucking about with repository permissions improperly.
There should be no output if nothing changed. So remove outputif.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: scripts: ensure repo root has proper permissions (bug 1186992); r?fubar

scripts: ensure repo root has proper permissions (bug 1186992); r?fubar

We weren't adjusting permissions on the root directory of the
repository. Derp.

Comment 3

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8638056 [details]
MozReview Request: ansible/hg-web: remove outputif from permissions cron (bug 1186992); r?fubar

https://reviewboard.mozilla.org/r/14023/#review12541

Ship It!

Comment 4

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8638057 [details]
MozReview Request: scripts: ensure repo root has proper permissions (bug 1186992); r?fubar

https://reviewboard.mozilla.org/r/14025/#review12543

Ship It!

Comment 5

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/9f5db4742f2fd3e6bf35a52585aac07cab8a7337
changeset:  9f5db4742f2fd3e6bf35a52585aac07cab8a7337
user:       Gregory Szorc <[e-mail]>
date:       Thu Jul 23 11:15:29 2015 -0700
description:
ansible/hg-web: remove outputif from permissions cron (bug 1186992); r=fubar

We want to receive email reports of what changed so we can identify
processes that are mucking about with repository permissions improperly.
There should be no output if nothing changed. So remove outputif.

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/cba501d98a9a100523f68594ccf09b9d05d4d39a
changeset:  cba501d98a9a100523f68594ccf09b9d05d4d39a
user:       Gregory Szorc <[e-mail]>
date:       Thu Jul 23 11:24:44 2015 -0700
description:
scripts: ensure repo root has proper permissions (bug 1186992); r=fubar

We weren't adjusting permissions on the root directory of the
repository. Derp.

Comment 6

[Gregory Szorc [:gps]]

Deploying now.

Comment 7

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/262fad606d6b360ada4bf456e4ce1c39db3fa5d5
changeset:  262fad606d6b360ada4bf456e4ce1c39db3fa5d5
user:       Gregory Szorc <[e-mail]>
date:       Fri Jul 24 10:19:38 2015 -0700
description:
scripts: use proper variable when adjusting repo root permissions (bug 1186992)

This is a follow-up from cba501d98a9a, which used a variable before
assignment.