Closed
Bug 1186992
Opened 9 years ago
Closed 9 years ago
Follows up repository permissions normalization
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(2 files)
I found a few issues with the initial landing of the repository permissions normalization from bug 1186256. 1. By using outputif in the CRON, we don't get summaries of what actually changed unless the script exits with a non-0 exit code. I want to get output emails because I want to find processes responsible for applying bad permissions. 2. The repository root directory itself doesn't have its permissions adjusted. Although, if we start adjusting permissions outside of .hg, we need to be careful for repos that have checkouts. (There should be no repos with checkouts.)
Assignee | ||
Comment 1•9 years ago
|
||
ansible/hg-web: remove outputif from permissions cron (bug 1186992); r?fubar We want to receive email reports of what changed so we can identify processes that are mucking about with repository permissions improperly. There should be no output if nothing changed. So remove outputif.
Attachment #8638056 -
Flags: review?(klibby)
Assignee | ||
Comment 2•9 years ago
|
||
scripts: ensure repo root has proper permissions (bug 1186992); r?fubar We weren't adjusting permissions on the root directory of the repository. Derp.
Attachment #8638057 -
Flags: review?(klibby)
Comment 3•9 years ago
|
||
Comment on attachment 8638056 [details] MozReview Request: ansible/hg-web: remove outputif from permissions cron (bug 1186992); r?fubar https://reviewboard.mozilla.org/r/14023/#review12541 Ship It!
Attachment #8638056 -
Flags: review?(klibby) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8638057 [details] MozReview Request: scripts: ensure repo root has proper permissions (bug 1186992); r?fubar https://reviewboard.mozilla.org/r/14025/#review12543 Ship It!
Attachment #8638057 -
Flags: review?(klibby) → review+
Assignee | ||
Comment 5•9 years ago
|
||
url: https://hg.mozilla.org/hgcustom/version-control-tools/rev/9f5db4742f2fd3e6bf35a52585aac07cab8a7337 changeset: 9f5db4742f2fd3e6bf35a52585aac07cab8a7337 user: Gregory Szorc <gps@mozilla.com> date: Thu Jul 23 11:15:29 2015 -0700 description: ansible/hg-web: remove outputif from permissions cron (bug 1186992); r=fubar We want to receive email reports of what changed so we can identify processes that are mucking about with repository permissions improperly. There should be no output if nothing changed. So remove outputif. url: https://hg.mozilla.org/hgcustom/version-control-tools/rev/cba501d98a9a100523f68594ccf09b9d05d4d39a changeset: cba501d98a9a100523f68594ccf09b9d05d4d39a user: Gregory Szorc <gps@mozilla.com> date: Thu Jul 23 11:24:44 2015 -0700 description: scripts: ensure repo root has proper permissions (bug 1186992); r=fubar We weren't adjusting permissions on the root directory of the repository. Derp.
Assignee | ||
Comment 6•9 years ago
|
||
Deploying now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•9 years ago
|
||
url: https://hg.mozilla.org/hgcustom/version-control-tools/rev/262fad606d6b360ada4bf456e4ce1c39db3fa5d5 changeset: 262fad606d6b360ada4bf456e4ce1c39db3fa5d5 user: Gregory Szorc <gps@mozilla.com> date: Fri Jul 24 10:19:38 2015 -0700 description: scripts: use proper variable when adjusting repo root permissions (bug 1186992) This is a follow-up from cba501d98a9a, which used a variable before assignment.
You need to log in
before you can comment on or make changes to this bug.
Description
•