Use Chaos Mode environment variable in XPCShell

RESOLVED FIXED in Firefox 43

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

(Blocks 1 bug)

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

In bug 1182516, MOZ_CHAOSMODE was added to control chaos mode from an env var.

I'd like to have it in XPCShell tests as well.
Bug 1186993 - Add MOZ_CHAOSMODE to XPCShell. r=roc
Attachment #8638059 - Flags: review?(roc)
No longer blocks: 1182298
Blocks: 1141544
Keywords: checkin-needed
Maybe this should of went into ChoasMode.h as a static inline?
What is the status of this bug?
Flags: needinfo?(jryans)
(In reply to Nick Fitzgerald [:fitzgen][:nf] from comment #5)
> What is the status of this bug?

I believe it could land as-is, but it does essentially duplicate code.

I have not had time to look at this again to try Beniot's static inline suggestion.

Benoit, is it okay to land the existing patch?
Flags: needinfo?(jryans) → needinfo?(bgirard)
Yea it's fine
Flags: needinfo?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/f0563b886a8e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.