1187000 - No graphical way to display e10s data in perfherder compare view

Status: RESOLVED FIXED

Description

[Joel Maher ( :jmaher ) (UTC-4)]

looking at two revisions which I know has e10s data:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=8d262d1d0ae5&newProject=mozilla-central&newRevision=15155971639c

I do not see any reference to e10s.  We have a url option &e10s=1 which doesn't work right now, but we should make a checkbox or link to avoid the magic url param discovery thing.

Comment 1

[William Lachance (:wlach) (use needinfo!)]

Just pushed a change that makes "&e10s=1" work. You can see this on stage:

https://treeherder.allizom.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=8d262d1d0ae5&newProject=mozilla-central&newRevision=15155971639c&e10s=1

Is there any reason we shouldn't just show everything by default? I'd rather do that than have a confusing checkbox that only actually works for some branches.

Comment 2

[Joel Maher ( :jmaher ) (UTC-4)]

I vote for showing everything by default.  Although it will make the list a LOT longer.

Comment 3

[William Lachance (:wlach) (use needinfo!)]

As an alternative, I suppose if we find e10s results we could show a banner in the actual compare view with two options:

[ Show everything ] [ Show e10s only ] [ Show only non-e10s ]

Thoughts?

Comment 4

[Joel Maher ( :jmaher ) (UTC-4)]

ideally compare view will be redone to show a lot of simple filters:
* e10s +-
* pgo +-
* ignoreNoData
* ignore minor changes

and maybe more.

Comment 5

[William Lachance (:wlach) (use needinfo!)]

Created attachment 8638154 [details]
Screen Shot 2015-07-23 at 5.32.50 PM.png

Maybe just a row of filter elements to show/hide the different options?

See a screenshot for details.

CC'ing :bwinton and :avih for second and third opinions.

Comment 6

[Joel Maher ( :jmaher ) (UTC-4)]

Comment on attachment 8638154 [details]
Screen Shot 2015-07-23 at 5.32.50 PM.png

I like this stuff!

Comment 7

[Avi Halachmi (:avih)]

Comment on attachment 8638154 [details]
Screen Shot 2015-07-23 at 5.32.50 PM.png

I _think_ right now e10s is only PGO, so it should probably be: opt / pgo / pgo(e10s) ?

If in the future we'd also have opt(e10s), then we could add that too.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8638154 [details]
Screen Shot 2015-07-23 at 5.32.50 PM.png

In general, I'm not a fan of options, but I think I need more context here before saying one way or the other.  (Grab me some time tomorrow?)

Comment 9

[William Lachance (:wlach) (use needinfo!)]

Updating the description to show the actual problem.

This keeps on biting people so I'm going to address it this week, when I return from holiday tomorrow anyway.

Comment 10

[William Lachance (:wlach) (use needinfo!)]

Picking this up again.

Comment 11

[William Lachance (:wlach) (use needinfo!)]

Created attachment 8674993 [details] [review]
Always show e10s data in compare view

This PR should fix the immediate issue while we figure out a better interface for filtering, etc.

Comment 12

[Joel Maher ( :jmaher ) (UTC-4)]

Comment on attachment 8674993 [details] [review]
Always show e10s data in compare view

great, step1 - show all tests!

Comment 13

[Treeherder Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/626678ab83f5555e8822f105ed79d6eeae9d3e73
Bug 1187000 - Always show e10s data in compare view

We can add some kind of a filtering interface later, but until that's
ready it's confusing to just not display it unless people specify
a magic flag (e10s=1).

Comment 14

[William Lachance (:wlach) (use needinfo!)]

Let's resolve this. I filed bug 1215617 to deal with the issue of creating a proper filtering interface for the compare view.