Make the Treeherder UI more clear about what it's doing when the "Get next NN" button is clicked

NEW
Unassigned

Status

Tree Management
Treeherder: Frontend
P3
normal
3 years ago
8 months ago

People

(Reporter: jmaher, Unassigned)

Tracking

Details

(Reporter)

Description

3 years ago
when the links don't work, they shouldn't be shown.  This is in the case of url params fromchange=<rev>&tochange=<rev>.
Absolutely not. Fromchange/tochange is added to URLs by default when you use the "Get next NN" button, so you'd totally break the functionality by doing that. Moreso, we use this for bisection all the time.

Seth asked for better UI exposing of this feature, not killing it outright.
(Reporter)

Comment 2

3 years ago
ok, then it should work!
It works exactly like it's supposed to.

This bug as filed is a WONTFIX. We can either resolve it as such and file a new bug for making the UX better as Seth requested or we can repurpose this one.
Flags: needinfo?(jmaher)
(Reporter)

Comment 4

3 years ago
yeah, I must have misunderstood the problem seth was having, lets repurpose this bug then.  I would rather we make things useful!
Flags: needinfo?(jmaher)
Seth's point of contention was that it wasn't obvious that clicking "Get next NN" was taking him outside the originally-specified range from the URL he was given. We can make that clearer in the UI without breaking things.
Summary: when using fromchange/tochange in the url, we should remove the get XX revisions, it is confusing → Make the Treeherder UI more clear about what it's doing when the "Get next NN" button is clicked

Updated

3 years ago
Priority: -- → P3

Updated

8 months ago
Component: Treeherder → Treeherder: Frontend
You need to log in before you can comment on or make changes to this bug.