1187007 - Display name field keeps focus outline even after pressing cancel

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: sync-focus.png

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1187007.patch

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8638693 [details] [diff] [review]
bug-1187007.patch

Review of attachment 8638693 [details] [diff] [review]:
-----------------------------------------------------------------

Strange that I don't see the problem on Windows. Wouldn't it be better to just .focus() the "change" button?

Comment 3

[Edouard Oger [:eoger]]

Attachment: focus on button.gif

I tried to focus the button and unfortunately on mac osx it feels really weird.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

We discussed on IRC that the .blur() (with a comment why it is necessary - it shouldn't be) and a .focus() of the change button (so an element close to the previously focused element gets final focus) is ok.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

hrm - now I'm not so sure :/ On my mac:

Try these str:
* Open prefs - device textbox has no border/highlight/focusring/whatever-it-is
* Click "change" - gets the ring.
* Click "cancel" - keeps the ring (ie, the point of this bug)
* Press Tab a few times.

Note how focus shifts to other elements, but that ring remains - so the issue doesn't seem to be focus but "something else" - we should find what that is.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(well - focus related, but if there is a blur event going missing it seems worth digging into a little)

Comment 7

[Edouard Oger [:eoger]]

The |disabled| property setter doesn't seem to blur its attached element when set to true, maybe we should fill a bug for this?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

(In reply to Edouard Oger [:eoger] from comment #7)
> The |disabled| property setter doesn't seem to blur its attached element
> when set to true, maybe we should fill a bug for this?

I think the element is losing focus (as focus moves to other elements) - so I suspect something like the blur event isn't delivered to disabled elements rather than auto-bluring it on being disabled.

Comment 9

[Edouard Oger [:eoger]]

Filed XUL bug 1194032

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Sorry if there's been some confusion, but can you please put up a tweaked patch with what comment 4 says (assuming it works) and with a comment referencing that older focus-related bug, with r=me and checkin-needed etc.

Comment 11

[Edouard Oger [:eoger]]

Attachment: bug-1187007.patch

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/498b7d4817e1

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/498b7d4817e1

Comment 14

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox nightly Version 42.0a1

It's fixed and verified on Latest Developer Edition
Build ID 	20151017004025
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0

Tested OS- Windows8.1 32bit

Comment 15

[Petruta Horea [:phorea]]

Thanks!
Marking as verified.