Closed
Bug 1187007
Opened 9 years ago
Closed 9 years ago
Display name field keeps focus outline even after pressing cancel
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | verified |
People
(Reporter: rfeeley, Assigned: eoger)
Details
Attachments
(3 files, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8638693 -
Flags: review?(markh)
Comment 2•9 years ago
|
||
Comment on attachment 8638693 [details] [diff] [review] bug-1187007.patch Review of attachment 8638693 [details] [diff] [review]: ----------------------------------------------------------------- Strange that I don't see the problem on Windows. Wouldn't it be better to just .focus() the "change" button?
Attachment #8638693 -
Flags: review?(markh)
Assignee | ||
Comment 3•9 years ago
|
||
I tried to focus the button and unfortunately on mac osx it feels really weird.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(markh)
Comment 4•9 years ago
|
||
We discussed on IRC that the .blur() (with a comment why it is necessary - it shouldn't be) and a .focus() of the change button (so an element close to the previously focused element gets final focus) is ok.
Flags: needinfo?(markh)
Comment 5•9 years ago
|
||
hrm - now I'm not so sure :/ On my mac: Try these str: * Open prefs - device textbox has no border/highlight/focusring/whatever-it-is * Click "change" - gets the ring. * Click "cancel" - keeps the ring (ie, the point of this bug) * Press Tab a few times. Note how focus shifts to other elements, but that ring remains - so the issue doesn't seem to be focus but "something else" - we should find what that is.
Comment 6•9 years ago
|
||
(well - focus related, but if there is a blur event going missing it seems worth digging into a little)
Assignee | ||
Comment 7•9 years ago
|
||
The |disabled| property setter doesn't seem to blur its attached element when set to true, maybe we should fill a bug for this?
Comment 8•9 years ago
|
||
(In reply to Edouard Oger [:eoger] from comment #7) > The |disabled| property setter doesn't seem to blur its attached element > when set to true, maybe we should fill a bug for this? I think the element is losing focus (as focus moves to other elements) - so I suspect something like the blur event isn't delivered to disabled elements rather than auto-bluring it on being disabled.
Assignee | ||
Comment 9•9 years ago
|
||
Filed XUL bug 1194032
Comment 10•9 years ago
|
||
Sorry if there's been some confusion, but can you please put up a tweaked patch with what comment 4 says (assuming it works) and with a comment referencing that older focus-related bug, with r=me and checkin-needed etc.
Flags: needinfo?(edouard.oger)
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8638693 -
Attachment is obsolete: true
Flags: needinfo?(edouard.oger)
Attachment #8652459 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/498b7d4817e1
Keywords: checkin-needed
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/498b7d4817e1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 14•9 years ago
|
||
I have reproduced this bug on Firefox nightly Version 42.0a1 It's fixed and verified on Latest Developer Edition Build ID 20151017004025 User Agent Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0 Tested OS- Windows8.1 32bit
QA Whiteboard: [testday-20151016]
You need to log in
before you can comment on or make changes to this bug.
Description
•