Use conservativeCollapse everywhere in grunt build

RESOLVED FIXED

Status

Tree Management
Treeherder
P4
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

We should stop doing this. Collapsing whitespace can create artificial differences between what we're testing and what we're deploying (see https://github.com/mozilla/treeherder/pull/801#issuecomment-124178728) and the savings are negligible (since whitespace gzips anyway).
Actually it turns out that we should be able to get the same effect by using 'conservativeCollapse': true everywhere (which :jfrench had already partly put in as part of bug 1087314)
Summary: We shouldn't collapse whitespace during a grunt build → Use conservativeCollapse everywhere in grunt build
Created attachment 8638107 [details] [review]
Use conservativeCollapse everywhere
Attachment #8638107 - Flags: review?(tojonmz)
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: -- → P4
Hardware: Unspecified → All
Comment on attachment 8638107 [details] [review]
Use conservativeCollapse everywhere

lgtm in the absence of local testing :) We should in theory only see changes in the Perf UI.

Yes, we had done this in Treeherder (only) for bug 1087314 back in
https://github.com/mozilla/treeherder-ui-deprecated/pull/250/files

I'm not sure if there is any risk to adding it to logviewer or not.
Attachment #8638107 - Flags: review?(tojonmz) → review+
Pushed to stage, seems to be working well.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.