Closed Bug 1187094 Opened 5 years ago Closed 5 years ago

ARM64: Move Lowering's visitConstant() to shared code

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: sstangl, Assigned: sstangl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

While implementing ARM64 Ion support, I am aiming to move all code that should have been shared across platforms into shared code. In particular, nbp enjoys this kind of patch, so likely all such reviews will be sent that way :)

10 files changed, 18 insertions(+), 105 deletions(-)
Attachment #8638177 - Flags: review?(nicolas.b.pierron)
Assignee: nobody → sstangl
Comment on attachment 8638177 [details] [diff] [review]
0001-Move-Lowering-s-visitConstant-to-shared-code.-r.patch

Review of attachment 8638177 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing it :)

This would reduce the overhead of adding new architecture, and hopefully ensure that we keep improving all architectures at the same time.
Attachment #8638177 - Flags: review?(nicolas.b.pierron) → review+
Ah, apparently I need to build locally with -Werror.
Flags: needinfo?(sstangl)
Honestly, I have no idea what is causing this error. Every file that uses define() also includes "jit/shared/Lowering-shared-inl.h", which includes the definition of define().
This follow-up fixes the missing "-inl.h" that caused the tree to burn. With this patch, a non-unified build (FILES_PER_UNIFIED_FILE=1) with --enable-warnings-as-errors builds and passes "make check-style".
Attachment #8639568 - Flags: review?(efaustbmo)
Comment on attachment 8639568 [details] [diff] [review]
0001-Fix-non-unified-build.patch

Review of attachment 8639568 [details] [diff] [review]:
-----------------------------------------------------------------

APPROVED.
Attachment #8639568 - Flags: review?(efaustbmo) → review+
You need to log in before you can comment on or make changes to this bug.