1187094 - ARM64: Move Lowering's visitConstant() to shared code

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Move-Lowering-s-visitConstant-to-shared-code.-r.patch

While implementing ARM64 Ion support, I am aiming to move all code that should have been shared across platforms into shared code. In particular, nbp enjoys this kind of patch, so likely all such reviews will be sent that way :)

10 files changed, 18 insertions(+), 105 deletions(-)

Comment 1

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8638177 [details] [diff] [review]
0001-Move-Lowering-s-visitConstant-to-shared-code.-r.patch

Review of attachment 8638177 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing it :)

This would reduce the overhead of adding new architecture, and hopefully ensure that we keep improving all architectures at the same time.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1df23b6a3f

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/be62b4f7b24c for build failures

https://treeherder.mozilla.org/logviewer.html#?job_id=12101816&repo=mozilla-inbound

Comment 4

[Sean Stangl [:sstangl]]

Ah, apparently I need to build locally with -Werror.

Comment 5

[Sean Stangl [:sstangl]]

Honestly, I have no idea what is causing this error. Every file that uses define() also includes "jit/shared/Lowering-shared-inl.h", which includes the definition of define().

Comment 6

[Sean Stangl [:sstangl]]

Attachment: 0001-Fix-non-unified-build.patch

This follow-up fixes the missing "-inl.h" that caused the tree to burn. With this patch, a non-unified build (FILES_PER_UNIFIED_FILE=1) with --enable-warnings-as-errors builds and passes "make check-style".

Comment 7

[Eric Faust [:efaust]]

Comment on attachment 8639568 [details] [diff] [review]
0001-Fix-non-unified-build.patch

Review of attachment 8639568 [details] [diff] [review]:
-----------------------------------------------------------------

APPROVED.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05fd68b041a8
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba20cbc9e74

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/05fd68b041a8
https://hg.mozilla.org/mozilla-central/rev/2ba20cbc9e74