1187124 - M-C configure produced comm-central/mozilla/configure: 21060: test: Illegal number:

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[ISHIKAWA, Chiaki]

Attachment: configure.in.patch

(Very similar to bug 1165733)
After refreshing the source code today, and trying to
link with gtk+-3 library (yay!),
I noticed an error during configure. 
(This is from C-C TB build, but should be applicable to M-C firefox build, too.)

/NREF-COMM-CENTRAL/comm-central/mozilla/configure: 21060: test: Illegal number: 

21060	
21061	if test "$MOZ_WIDGET_TOOLKIT" = "gonk" -a -n "$MOZ_FMP4" -a "$ANDROID_VERSION" -ge "18"; then
21062	    MOZ_GONK_MEDIACODEC=1
21063	    
21064	fi
21065	

Looking at 21061 and, not knowing whether MOZ_WIDGET_TOOKIT is always
set to non-empty string, I am tempted to rewrite the first part as
test x"$MOZ_WIDGET_TOOLKIT" = x"gonk" ...

But the real problem I faced is, I think, ANDROID_VERSION is probably
not set on my PC. I am building this for ordinary Debian GNU/Linux.

So trying to refer to $ANDROID_VERSION as a number in "... -ge 18"
context ONLY when it is not an empty string, I rewrote this part as
below.

if test x"$MOZ_WIDGET_TOOLKIT" = x"gonk" -a -n "$MOZ_FMP4" -a -n "$ANDROID_VERSION"; then
    if test "$ANDROID_VERSION" -ge "18"; then
        MOZ_GONK_MEDIACODEC=1
    fi
fi

As it turned out, I need to change mozilla/configure.in.

Patch is attached.

It ran successfully on local PC (Debian GNU/Linux).

test harness probably should check for typical errors during configure such as "test: illegal number", "test: integer expresion expected", etc.

TIA

Comment 1

[ISHIKAWA, Chiaki]

Thank you. I put in checkin-needed keyword.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcb9d39d3ee8

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dcb9d39d3ee8