Closed Bug 1187138 Opened 4 years ago Closed 4 years ago

Replace nsBaseHashtable::Enumerate() calls in toolkit/ with iterators

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(4 files)

Because iterators are so much nicer than enumerate functions.

There are nine occurrences of Enumerate() in this directory

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::Data() rather than nsBaseHashtable::Iterator::UserData(). (The latter should be used when replacing nsBaseHashtable::EnumerateRead()).
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Attachment #8681747 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ba2c4af609475fb6cae349fb0755b2b55cbb0e8
Bug 1187138 (part 1) - Replace nsBaseHashtable::Enumerate() calls in toolkit/ with iterators. r=froydnj.
https://hg.mozilla.org/mozilla-central/rev/0ba2c4af6094
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Whoops; more to do here.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8681747 - Flags: checkin+
Attachment #8691142 - Flags: review?(nfroyd) → review+
Attachment #8691195 - Flags: review?(nfroyd) → review+
Attachment #8691196 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5bcfd49772cf272f915c527c79316715b6caa38
Bug 1187138 (part 2) - Replace nsBaseHashtable::Enumerate() calls in toolkit/ with iterators. r=froydnj.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8916a64bc80e052f9ba82b14bf81fcfc0da23d49
Bug 1187138 (part 3) - Replace nsBaseHashtable::Enumerate() calls in toolkit/ with iterators. r=froydnj.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6457df30a83a8ad67055b5f5276ac87b548b72dd
Bug 1187138 (part 4) - Replace nsBaseHashtable::Enumerate() calls in toolkit/ with iterators. r=froydnj.
You need to log in before you can comment on or make changes to this bug.