Closed Bug 1187155 Opened 5 years ago Closed 5 years ago

Remove #include <sphelper.h> for VS2013 express

Categories

(Core :: DOM: Core & HTML, defect)

All
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1003457 +++

VS2013 Express has no ATL headers, but sphelper.h into Windows SDK uses ATL.  So we should replace sphelper.h with sapi.h
Comment on attachment 8638272 [details] [diff] [review]
Remove sphelper.h dependency to avoid ATL

sphelper.h into Windows SDK includes atlbase.h.  So we should not use it for VS2013 express edition.

Also, I find memory leak, so we should fix it too.
Attachment #8638272 - Flags: review?(jmathies)
Comment on attachment 8638272 [details] [diff] [review]
Remove sphelper.h dependency to avoid ATL

Review of attachment 8638272 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webspeech/synth/windows/SapiService.cpp
@@ +237,2 @@
>    nsRefPtr<IEnumSpObjectTokens> voiceTokens;
> +  if (FAILED(category->EnumTokens(nullptr, nullptr, 

nit - a little white space snuck in here.
Attachment #8638272 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/5f2e5a9fb54d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.